Skip to content

Conversation

@pinebit
Copy link
Collaborator

@pinebit pinebit commented Oct 28, 2025

Improved behavior for older builds having unknown git hash:

  • to not warn aggressively, we can still show unknown in grafana
  • to not break metric submission flow

category: bug
ticket: #4001

@sonarqubecloud
Copy link

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 28, 2025
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.78%. Comparing base (a57d6b9) to head (340395b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/peerinfo/peerinfo.go 0.00% 1 Missing and 1 partial ⚠️
app/version/version.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4057      +/-   ##
==========================================
- Coverage   54.81%   54.78%   -0.03%     
==========================================
  Files         242      242              
  Lines       31038    31038              
==========================================
- Hits        17013    17004       -9     
- Misses      11786    11797      +11     
+ Partials     2239     2237       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@obol-bulldozer obol-bulldozer bot merged commit 5ae4203 into main Oct 28, 2025
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/unknown-git-hash branch October 28, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants