*: v1.6.1 #3975
Merged
*: v1.6.1 #3975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we fetch attestation data with the fetcher, we are doing this in a loop, which takes variable amount of time, based on the beacon node's performance. If the beacon node is underperforming it might be that in the middle of this loop it receives a new block. This will result some attestation datas having the up to date head, while others have an old head. In a good scenario of well performing beacon node, the heads will be the same and the `value` and `attData.Data` will be equal. However, in the scenario explained above, their head will missmatch, resulting in inequality. That's why we are checking here only if source and target missmatch. category: bug ticket: none
|
pinebit
approved these changes
Sep 12, 2025
DiogoSantoss
approved these changes
Sep 12, 2025
OisinKyne
approved these changes
Sep 12, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-v1.6 #3975 +/- ##
==========================================
Coverage 55.02% 55.03%
==========================================
Files 225 225
Lines 36857 36877 +20
==========================================
+ Hits 20282 20295 +13
- Misses 14430 14441 +11
+ Partials 2145 2141 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KaloyanTanev
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep for v1.6.1 release.
category: misc
ticket: none