dutydb: check only source and target for commidx 0 #3974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…committee index 0
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3974 +/- ##
==========================================
+ Coverage 55.08% 55.10% +0.02%
==========================================
Files 225 225
Lines 37237 37257 +20
==========================================
+ Hits 20511 20530 +19
- Misses 14555 14557 +2
+ Partials 2171 2170 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pinebit
approved these changes
Sep 12, 2025
DiogoSantoss
approved these changes
Sep 12, 2025
KaloyanTanev
added
the
merge when ready
obol-bulldozer
bot
deleted the
kalo/check-only-source-and-target-commidx0
branch
KaloyanTanev
added a commit
that referenced
this pull request
Sep 12, 2025
When we fetch attestation data with the fetcher, we are doing this in a loop, which takes variable amount of time, based on the beacon node's performance. If the beacon node is underperforming it might be that in the middle of this loop it receives a new block. This will result some attestation datas having the up to date head, while others have an old head. In a good scenario of well performing beacon node, the heads will be the same and the `value` and `attData.Data` will be equal. However, in the scenario explained above, their head will missmatch, resulting in inequality. That's why we are checking here only if source and target missmatch. category: bug ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we fetch attestation data with the fetcher, we are doing this in a loop, which takes variable amount of time, based on the beacon node's performance. If the beacon node is underperforming it might be that in the middle of this loop it receives a new block. This will result some attestation datas having the up to date head, while others have an old head.
In a good scenario of well performing beacon node, the heads will be the same and the
valueandattData.Datawill be equal. However, in the scenario explained above, their head will missmatch, resulting in inequality.That's why we are checking here only if source and target missmatch.
category: bug
ticket: none