Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: pin lighthouse version in compose tests #3188

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

KaloyanTanev
Copy link
Contributor

@KaloyanTanev KaloyanTanev commented Jul 23, 2024

  • Pin lighthouse version in Dockerfile for compose tests.
  • Remove stdin flag (doesn't exist in new version).
  • Add Docker images checks for dependabot.

category: bug
ticket: #3204

Copy link

sonarcloud bot commented Jul 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.76%. Comparing base (b3bb569) to head (cedc82d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3188      +/-   ##
==========================================
+ Coverage   56.70%   56.76%   +0.05%     
==========================================
  Files         208      208              
  Lines       29235    29235              
==========================================
+ Hits        16579    16595      +16     
+ Misses      10828    10814      -14     
+ Partials     1828     1826       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pinebit pinebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this works. Thank you!

@KaloyanTanev KaloyanTanev self-assigned this Jul 23, 2024
@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 23, 2024
@obol-bulldozer obol-bulldozer bot merged commit 06db397 into main Jul 23, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/pin-lighthouse-version branch July 23, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants