core/tracker: improved reasons wording #3033
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3033 +/- ##
==========================================
- Coverage 54.80% 54.80% -0.01%
==========================================
Files 206 206
Lines 28837 28837
==========================================
- Hits 15805 15804 -1
- Misses 11213 11215 +2
+ Partials 1819 1818 -1 ☔ View full report in Codecov by Sentry. |
| - *Summary*: couldn`t aggregate attestation due to insufficient partial beacon committee selections | ||
| - *Details*: Reason `fetcher_aggregator_few_prepares` indicates an attestation aggregation duty failed in the fetcher step since it couldn`t fetch the prerequisite aggregated beacon committee selections. This indicates the associated prepare aggregation duty failed due to insufficient partial beacon committee selections submitted by the cluster validator clients. | ||
| - *Details*: Reason `insufficient_aggregator_selections` indicates an attestation aggregation duty failed in the fetcher step since it couldn`t fetch the prerequisite aggregated beacon committee selections. This indicates the associated prepare aggregation duty failed due to insufficient partial beacon committee selections submitted by the cluster validator clients. |
There was a problem hiding this comment.
| - *Details*: Reason `insufficient_aggregator_selections` indicates an attestation aggregation duty failed in the fetcher step since it couldn`t fetch the prerequisite aggregated beacon committee selections. This indicates the associated prepare aggregation duty failed due to insufficient partial beacon committee selections submitted by the cluster validator clients. | |
| - *Details*: Reason `insufficient_aggregator_selections` indicates an attestation aggregation duty failed in the fetcher step since it couldn't fetch the prerequisite aggregated beacon committee selections. This indicates the associated prepare aggregation duty failed due to insufficient partial beacon committee selections submitted by the cluster validator clients. |
There might be more instances of back ticks used as apostrophes, it will break Markdown parsing.
There was a problem hiding this comment.
reasons.md is generated from reason.go. I cannot patch it manually as it will break the test.
There was a problem hiding this comment.
it does not seem break the markdown.
There was a problem hiding this comment.
We're lucky then! Backticks are used for inline code, weird that it doesn't break.
I'm approving then!
There was a problem hiding this comment.
I believe it looks for the second backtick on the same line. This is not triggered in this case.
Also, note that in our test, we explicitly replace all ' with ` here https://github.com/ObolNetwork/charon/blob/main/cmd/markdown_internal_test.go#L195
The source text (reason.go) contains '
pinebit
added
the
merge when ready
Improved operator UX by renaming tracker reasons to be more descriptive.
Verified Obol infra alerts and Dashboard V3 - these do not use the affected identifiers explicitly.
category: refactor
ticket: #2488