Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth2util/deposit: use legacy filename for 32ETH deposit #2940

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Mar 5, 2024

When partial deposit amounts are not used, the implementation defaults to the single deposit amount of 32ETH. In this case, we want the output filename to be deposit-data.json, not deposit-data-32eth.json. This is done for backward compatibility.

category: feature
ticket: #2948

Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.71%. Comparing base (4dfaed8) to head (865dcf2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2940      +/-   ##
==========================================
+ Coverage   53.64%   53.71%   +0.07%     
==========================================
  Files         202      202              
  Lines       28531    28536       +5     
==========================================
+ Hits        15305    15329      +24     
+ Misses      11311    11293      -18     
+ Partials     1915     1914       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Mar 6, 2024
@obol-bulldozer obol-bulldozer bot merged commit 02ee0ec into main Mar 6, 2024
14 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/legacy-filename-when-32eth branch March 6, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants