Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A deposit file for a single deposit should be backward compatible #2948

Closed
2 tasks done
boulder225 opened this issue Mar 6, 2024 · 0 comments
Closed
2 tasks done

A deposit file for a single deposit should be backward compatible #2948

boulder225 opened this issue Mar 6, 2024 · 0 comments
Assignees
@pinebit
Labels
protocol Protocol Team tickets v1-candidate

Comments

@boulder225
Copy link
Collaborator

boulder225 commented Mar 6, 2024 •
edited by pinebit
Loading

🎯 Problem to be solved

A deposit file for a single 32 ETH deposit requires naming consistency for backward compatibility.

🛠️ Proposed solution

When partial deposits are not used, the single 32eth deposit file should have legacy name: deposit-data.json, for backward compatibility

  • Implement a check in the deposit file generation process to detect when a single 32 ETH deposit is made without using partial deposits.
  • ensure the deposit file is named deposit-data.json instead of following the new naming convention.
@github-actions github-actions bot added the protocol Protocol Team tickets label Mar 6, 2024
@pinebit pinebit mentioned this issue Mar 6, 2024
Merged
obol-bulldozer bot pushed a commit that referenced this issue Mar 6, 2024
@pinebit
eth2util/deposit: use legacy filename for 32ETH deposit (#2940)
02ee0ec 
When partial deposit amounts are not used, the implementation defaults to the single deposit amount of 32ETH. In this case, we want the output filename to be `deposit-data.json`, not `deposit-data-32eth.json`. This is done for backward compatibility.

category: feature
ticket: #2948
@pinebit pinebit closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinebit pinebit

Labels
protocol Protocol Team tickets v1-candidate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pinebit @boulder225