Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: cluster hash mismatch error #2414

Closed
wants to merge 2 commits into from
Closed

Conversation

xenowits
Copy link
Contributor

Return error if clusters loaded from legacy lock and manifest files don't have the same cluster hash.

category: feature
ticket: #2335

@xenowits xenowits self-assigned this Jul 10, 2023
cluster/manifest/load.go Outdated Show resolved Hide resolved
cluster/manifest/load.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 90.90% and project coverage change: +0.08 🎉

Comparison is base (ffe4966) 53.67% compared to head (5440d98) 53.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2414      +/-   ##
==========================================
+ Coverage   53.67%   53.75%   +0.08%     
==========================================
  Files         196      196              
  Lines       26326    26345      +19     
==========================================
+ Hits        14130    14163      +33     
+ Misses      10441    10427      -14     
  Partials     1755     1755              
Impacted Files Coverage Δ
cluster/manifest/load.go 74.50% <90.90%> (+24.50%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xenowits xenowits added merge when ready Indicates bulldozer bot may merge when all checks pass and removed merge when ready Indicates bulldozer bot may merge when all checks pass labels Jul 25, 2023
@xenowits xenowits closed this Jul 28, 2023
@dB2510 dB2510 deleted the xenowits/match-hashes branch November 8, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants