Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster hashes should match in manifest and lock #2335

Closed
3 tasks
xenowits opened this issue Jun 19, 2023 · 2 comments
Closed
3 tasks

cluster hashes should match in manifest and lock #2335

xenowits opened this issue Jun 19, 2023 · 2 comments
Assignees
Labels
protocol Protocol Team tickets

Comments

@xenowits
Copy link
Contributor

xenowits commented Jun 19, 2023

🎯 Problem to be solved

Users can provide both cluster-manifest.pb and cluster-lock.json files to charon commands such as charon run. In such cases, for safety, we can verify that the cluster hashes in both these files match.

🛠️ Proposed solution

If both legacy lock and manifest files are found, load both files. Ensure that the cluster hashes match, ie, that the manifest contains that legacy lock. Else error with mismatching manifest and legacy lock found.

🧪 Tests

  • Tested by new automated unit/integration/smoke tests
  • Manually tested on core team/canary/test clusters
  • Manually tested on local compose simnet

👐 Additional acceptance criteria

None

❌ Out of Scope

None

@github-actions github-actions bot added the protocol Protocol Team tickets label Jun 19, 2023
@OisinKyne
Copy link
Contributor

I don't think we should have definition and lock files as part of the manifest flow, what is the benefit? what does the user journey look like? How does the launchpad flow change to accomodate this?

@corverroos
Copy link
Contributor

@OisinKyne see our comments in #2334. Adding support for both legacy lock files and new manifest files is required to support both old and new cluster configuration with the same code base.

@xenowits xenowits self-assigned this Jun 26, 2023
obol-bulldozer bot pushed a commit that referenced this issue Aug 1, 2023
Return error if clusters loaded from legacy lock and manifest files don't have the same cluster hash.

category: feature 
ticket: #2335
@xenowits xenowits closed this as completed Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

3 participants