PHPCS Integration Composer Package #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the appropriate configuration changes to support distributing the package via Packagist & Composer.
This reverts commit 84b783a.
A new `phpCodeSniffer.autoloadPHPCSIntegration` option allows for using an autoloaded set of integration files from a Composer package instead of a file path to them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This pull request sets up a Composer package for the integration files and adds a new configuration option to make it possible to use it instead of the integrated reports. This is useful for cases where the path to the report files from the extension are not available. This is primarily the case when using a Docker environment but not using a remote extension.
How to test the changes in this Pull Request:
phpCodeSniffer.autoloadPHPCSIntegrationsetting. It should give an error about a missing report.pathrepository to acomposer.jsonfile in a project you want to test against.composer require -D "obliviousharmony/vscode-phpcs-integration"="*"