Support Overriding PHPCS Integration Path #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently some very specific use-cases that we don't support. In order to add features like that without bloating our config we can use an aggregate config setting that only gets filled out when a user needs to set one of the parameters.
This makes some changes so that we can pass the path to the PHPCS integration files from the configuration object. This is useful so that we can support the override.
ObliviousHarmony
added a commit
that referenced
this pull request
Jan 29, 2024
This reverts commit 84b783a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
In order to support narrow use-cases without bloating the settings we're going to add a new
specialOptionssetting. This can contain any of these optional settings in a single setting. The first of these settings isphpcsIntegrationPathOverride. This allows developers to override the path to the PHPCS integration files in case they're using PHP in a container but not using a VS Code remote extension.Closes #86.
How to test the changes in this Pull Request: