Expand Low Pressure Table Padding to Oil Property Tables #4555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This is work in progress and not ready for merging at this time. I'm merely creating a PR to facilitate broader testing. |
|
jenkins build this failure_report please |
|
The following two cases did not run through, |
The |
bska
force-pushed
the
expand-low-pressure-handling-to-oil-pvt
branch
7 times, most recently
from
cf93577 to
cfd6cf6
Compare
bska
force-pushed
the
expand-low-pressure-handling-to-oil-pvt
branch
from
cfd6cf6 to
2050094
Compare
bska
force-pushed
the
expand-low-pressure-handling-to-oil-pvt
branch
6 times, most recently
from
16e39af to
a653fc7
Compare
bska
force-pushed
the
expand-low-pressure-handling-to-oil-pvt
branch
5 times, most recently
from
6841be7 to
0c68548
Compare
bska
added
the
manual:new-feature
bska
force-pushed
the
expand-low-pressure-handling-to-oil-pvt
branch
4 times, most recently
from
86d4fea to
a4f6c8c
Compare
bska
force-pushed
the
expand-low-pressure-handling-to-oil-pvt
branch
2 times, most recently
from
ae681e8 to
b574ad0
Compare
bska
force-pushed
the
expand-low-pressure-handling-to-oil-pvt
branch
13 times, most recently
from
b3115d9 to
f6217fb
Compare
bska
force-pushed
the
expand-low-pressure-handling-to-oil-pvt
branch
9 times, most recently
from
511c309 to
e37ef7d
Compare
bska
force-pushed
the
expand-low-pressure-handling-to-oil-pvt
branch
5 times, most recently
from
0e3496d to
6345dce
Compare
This commit adds a procedure for expanding missing undersaturated
states in PVTO/PVTG in the low-level Pvt*Table classes on top of
which the higher level types are built. This, as an added benefit,
directly ensures that we emit fully expanded PVTO/PVTG tables to the
.INIT file.
To this end, equip the base class PvtxTable with a helper function
void PvtxTable::populateMissingUndersaturatedStates()
which will invoke the virtual function
makeScaledUSatTableCopy(src, dest)
in its derived classes--especially PvtoTable and PvtgTable--for each
missing undersaturated state. The type-specific procedures for
PvtoTable and PvtgTable is defined in such a way that the scaled
copies preserve oil compressibility.
This commit adds a procedure for padding live oil (PVTO) tables at low oil pressures. The primary objective is to avoid generating negative Rs values when extrapolating the RsSat(po) curve linearly to low oil pressures. To this end, compute a limiting pressure based on inverse interpolation at Rs=1.0e-6 (could possibly be made configurable) and pad the table if this limiting pressure exceeds atmospheric pressure. We pad the table with a composition node at Rs=0. This node is then assigned either to atmospheric pressure or the limiting pressure value. Associate Bo and vo values defined by linear extrapolation to these pressure values. We add a second composition node at Rs=1.0e-6 if the limiting pressure exceeds atmospheric pressure.
bska
force-pushed
the
expand-low-pressure-handling-to-oil-pvt
branch
from
6345dce to
c049283
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a procedure for padding live oil (PVTO) tables at low oil pressures. The primary objective is to avoid generating negative Rs values when extrapolating the RsSat(po) curve linearly to low oil pressures. To this end, compute a limiting pressure based on inverse interpolation at$R_s=10^{-6}$ (could possibly be made configurable) and pad the table if this limiting pressure exceeds atmospheric pressure.
We pad the table with a composition node at$R_s=0$ . This node is then assigned either to atmospheric pressure or the limiting pressure value. Associate $B_o$ and $\mu_o$ values defined by linear extrapolation to these pressure values. We add a second composition node at $R_s=10^{-6}$ if the limiting pressure exceeds atmospheric pressure.
This PR is similar in spirit but different in details to the gas property low pressure table padding of PR #3779.