Add Conditional Low-Pressure Padding of Gas Property Tables #3779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am creating this PR in draft mode because it needs quite a lot of testing before we consider enabling this in the mainline simulator. |
|
jenkins build this please |
bska
force-pushed
the
low-pressure-gas-table-padding
branch
2 times, most recently
from
678035b to
b0772f0
Compare
|
jenkins build this please |
bska
force-pushed
the
low-pressure-gas-table-padding
branch
from
b0772f0 to
0615b69
Compare
|
jenkins build this please |
bska
force-pushed
the
low-pressure-gas-table-padding
branch
9 times, most recently
from
8bcb7d7 to
99e8833
Compare
|
jenkins build this please |
bska
force-pushed
the
low-pressure-gas-table-padding
branch
10 times, most recently
from
1647b1d to
bca7723
Compare
bska
force-pushed
the
low-pressure-gas-table-padding
branch
3 times, most recently
from
b4fb4f9 to
2194a00
Compare
bska
force-pushed
the
low-pressure-gas-table-padding
branch
2 times, most recently
from
dc4c66a to
5d5e5ad
Compare
I have reviewed the regression failures and they're mostly all of the expected form; the contents of the I recommend updating the reference solutions and merging this, but we should maybe/probably wait for the benchmark results before doing so? |
bska
force-pushed
the
low-pressure-gas-table-padding
branch
4 times, most recently
from
c270b21 to
181117a
Compare
I issued that request nearly 48 hours ago now. Is there a high system load on the benchmark runner, @blattms, or did I make a mistake somewhere? |
|
last time i triggered it took 50h. |
Okay. If that's the case now too then we'll have the response around 8pm CET today. |
bska
force-pushed
the
low-pressure-gas-table-padding
branch
2 times, most recently
from
db45441 to
abe7097
Compare
|
no objections. |
|
jenkins build this update_data please |
jenkins4opm
pushed a commit
to jenkins4opm/opm-tests
that referenced
this pull request
Feb 14, 2025
Reason: PR OPM/opm-common#3779 opm-common = 835d3aaca52e9f4f067dab4ca11b9423f32cb6de opm-grid = 6651530966139f91cc97d2952f658b97186f7faa opm-simulators = 835d3aaca52e9f4f067dab4ca11b9423f32cb6de ### Changed Tests ### * network_balance_01 * network_standard * network_01_reroute * network_01_reroute_std * gasoil_precsalt * jfunc_01 * pinch_nopinch_1x1x10 * numerical_aquifer_3d_2aqu * numerical_aquifer_3d_1aqu * aquflux_01 * spe3 * msw_2d_h * msw_3d_hfa * polymer_simple2D * wecon_wtest * base_model2 * base_model2_welpi * base_model2_let * 0a1_grpctl_stw_model2 * 0a1_grpctl_msw_model2 * 0a2_grpctl_stw_model2 * 0a2_grpctl_msw_model2 * 0a3_grpctl_stw_model2 * 0a3_grpctl_msw_model2 * 0a4_grpctl_stw_model2 * 0a4_grpctl_msw_model2 * multregt_model2 * udq_actionx * udq_wconprod * actionx_m1 * pinch_multz_all * pinch_multzm_all * pinch_multz_all_barrier * pinch_multzm_all_barrier * waghyst1 * waghyst2 * gpmaint11 * pinch_t1a_gap * pinch_t1a_nogap * pinch_t1a_nopinch * pinch_t1a1_nogap * pinch_t2a1_gap * pinch_t2a_nopinch * pinch_t2a_gap * pinch_t1b_nopinch * pinch_t1b1_gap * pinch_t1b2_gap * pinch_t1b3_gap * pinch_t1b4_gap * pinch_t1b5_gap * pinch_t1b6_gap * pinch_t1b7_gap * pinch_t1c_nopinch * pinch_t1c1_nogap * pinch_t1c1_gap * pinch_t1c2_gap * pinch_t1c2_nogap * pinch_t1c3_gap * pinch_t1c3_nogap * pinch_t1d_nopinch * pinch_t1d1_gap * pinch_t1d1_nogap * equalreg_multy_01 * equalreg_multy_02 * equalreg_multy_03 * equalreg_multy_04 * equalreg_multy_05 * equalreg_multy_06 * actionx_well_templ_01 * actionx_well_templ_02 * actionx_well_templ_03 * actionx_well_templ_04 * actionx_well_templ_05 * actionx_well_templ_06 * WCYCLE-0 * WCYCLE-1 * WCYCLE-2 * WCYCLE-3 * WCYCLE-4 * WCYCLE-5 * WCYCLE-6 * WCYCLE-7 * WCYCLE-8 * udq_uadd * udq_undefined * udq_in_actionx * reg_smry_in_fld_udq * group_udq * udq_undefined_2 * cskin-01 * cskin-02 * cskin-03 * cskin-04 * cskin-05 * ppcwmax * udq_pyaction * multxyz_model2 * multflt_model2 * multflt_sched_model2 * multpvv_model2 * swatinit_model2 * endscale_model2 * hysteresis_model2 * multiply_tranxyz_model2 * editnnc_model2 * fbhpdef_model2 * 9_1a_grpctl_stw_model2 * 9_1a_grpctl_msw_model2 * 9_1b_grpctl_stw_model2 * 9_1b_grpctl_msw_model2 * 9_2a_grpctl_stw_model2 * 9_2a_grpctl_msw_model2 * 9_2b_grpctl_stw_model2 * 9_2b_grpctl_msw_model2 * 9_3a_grpctl_stw_model2 * 9_3a_grpctl_msw_model2 * 9_3b_grpctl_stw_model2 * 9_3b_grpctl_msw_model2 * 9_3c_grpctl_stw_model2 * 9_3c_grpctl_msw_model2 * 9_3d_grpctl_stw_model2 * 9_3d_grpctl_msw_model2 * 9_3e_grpctl_stw_model2 * 9_3e_grpctl_msw_model2 * 9_4a_grpctl_stw_model2 * 9_4a_grpctl_msw_model2 * 9_4b_grpctl_stw_model2 * 9_4b_grpctl_msw_model2 * 9_4c_grpctl_stw_model2 * 9_4c_grpctl_msw_model2 * 9_4d_grpctl_stw_model2 * 9_4d_grpctl_msw_model2 * model4_udq_group * model4_gefac * wsegaicd * wsegvalv_2d_vert * nnc * nonnc * norne_reperf * compl_smry * 3d_tran_operator * actionx_gconprod * actionx_wefac * base_wt_tracer * base_wt_tracer(restart) * min_bhp_1 * min_bhp_2 * min_bhp_3 * min_thp_1 * max_gor_1 * min_gasrate_1 * min_qoil_1 * max_watercut_1 * max_watercut_2 * max_watercut_3 * max_watercut_4 * max_wgr_1 * rxft_smry * actionx_wpimult * wvfpexp_02 * krnum_02x * krnum_02y * krnum_02z * krnum_03x * krnum_03y * krnum_03z * 01_wgrupcon * 02_wgrupcon * 01_vappars * 01_multflt * 02_multflt * 03_multflt * 01_multregt * 05_multxyz * 06_multxyz * 07_multxyz * 08_multxyz * 11_multxyz * norne_init
|
jenkins build this opm-tests=1292 please |
This commit adds a new member function,
X emptyStructuralCopy() const
to the DeckKeyword and DeckItem classes. This member function will
form a "structural" copy of "*this", thus preserving aspects such as
the currently active "Dimensions", but removing all data values.
This is in preparation of adding low-pressure table expansion for
the gas PVT tables (i.e., keywords 'PVDG' and 'PVTG').
This commit adds logic to extend gas property tables entered using the PVDG or PVTG to low pressure values if needed. When we compute well production potentials (e.g., summary vectors WxPP) and the well's bottom-hole pressure limit is defaulted we end up using pressures in the order of one atmosphere (1 atm) and this, in turn, may generate negative formation volume factors (mass densities) and/or phase viscosities. The problem is most pronounced for producing wells in history matching mode (keyword WCONHIST), but we should have guards in place to avoid negative densities regardless. If needed we extend the tables down to 1 barsa and also insert a "limiting" pressure value PLim corresponding to a maximum FVF value in the range [1, 2]. In this case we create new input tables and redo the property table initialisation with this extended input table.
bska
force-pushed
the
low-pressure-gas-table-padding
branch
from
abe7097 to
f35bc83
Compare
|
jenkins build this opm-tests=1292 please |
bska
added a commit
to OPM/opm-tests
that referenced
this pull request
Feb 14, 2025
Automatic Reference Data Update for PR OPM/opm-common#3779
|
PR approved, build check is green, and the new reference solutions have been installed on the CI system. I'll merge this into the master branch now to enable the feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to extend gas property tables entered using the PVDG or PVTG keywords to low pressure values if needed. When we compute well production potentials (e.g., summary vectors WxPP) and the well's bottom-hole pressure limit is defaulted we end up using pressures in the order of one atmosphere (1 atm) and this, in turn, may generate negative formation volume factors (mass densities) and/or phase viscosities. The problem is most pronounced for producing wells in history matching mode (keyword WCONHIST), but we should have guards in place to avoid negative densities regardless.
If needed we extend the tables down to 1 barsa and also insert a "limiting" pressure value$p_{\mathrm{lim}}$ corresponding to a maximum FVF value in the range $[1, 10\cdot B_0]$ . In this case we create new input tables and redo the property table initialisation with this extended input table.
To this end, we add a way of creating empty
DeckItemandDeckKeywordobjects which preserve the structural elements of their live counterparts. This, in turn, enables programmatic creation of fullDeckItem/DeckKeywordobjects by first inserting the padding values and then copying the original table values into those objects.