Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rk3588 support #7056

Closed
wants to merge 1 commit into from
Closed

add rk3588 support #7056

wants to merge 1 commit into from

Conversation

n1ptune
Copy link

@n1ptune n1ptune commented Sep 26, 2024

support to rockchip rock5b which use rk3588

Copy link
Contributor

@jforissier jforissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some description to the commit and also your Signed-off-by:. And see my comment below. Thanks!

@@ -85,6 +85,25 @@
#define FIREWALL_DDR_BASE 0xff534000
#define FIREWALL_DDR_SIZE SIZE_K(16)

#elif defined(PLATFORM_FLAVOR_rk3588)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a SoC as the name of the flavor is not a good idea IMO. How would you name different boards using the same SoC? Although yes, ideally if we use DT and runtime detection etc. it may be possible but it doesn't seem to apply here.

@jforissier
Copy link
Contributor

jforissier commented Oct 2, 2024

This is very similar to #7059. @n1ptune can we close this one? But, back to my remark on the platform name, how would one build for Rock 5 or NanoPC-T6 if the OP-TEE PLATFORM= is the same (i.e., rockchip-rk3588)? @edtubbs

@edtubbs
Copy link

edtubbs commented Oct 2, 2024

This is very similar to #7059. @n1ptune can we close this one? But, back to my remark on the platform name, how would one build for Rock 5 or NanoPC-T6 if the OP-TEE PLATFORM= is the same (i.e., rockchip-rk3588)? @edtubbs

It seems like the build system handles this with the makefiles for specific boards, but we could extend the platform (e.g., PLATFORM_FLAVOR_rk3588_rock5) if board-level configuration is needed.

#define UART5_BASE 0xfeb80000
#define UART5_SIZE SIZE_K(64)

#define FIREWALL_DDR_BASE 0xfe030000
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see rk3588 has two firewalls: FIREWALL_DDR with base address 0xFE030000 and FIREWALL_SYSMEM with base address 0xFE038000 have you been able to find out the difference? I guess the FIREWALL_DDR hold MMU registers, and FIREWALL_SYSMEM holds SMMU registers, but I cannot confirm this.


register_phys_mem_pgdir(MEM_AREA_IO_SEC, FIREWALL_DDR_BASE, FIREWALL_DDR_SIZE);

int platform_secure_ddr_region(int rgn, paddr_t st, size_t sz)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How have you been able to find out how to set MMU configuration for this SoC? I cannot find any exact MMU register mappings in SoC's TRM.

Copy link

github-actions bot commented Nov 3, 2024

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Nov 3, 2024
@github-actions github-actions bot closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants