Skip to content

Conversation

@addledrabbit
Copy link
Contributor

I confirmed from documentation that Python/Pandas 's 'blue' is #0000ff in HEX. I then checked this in the suggested colour contrast checking tool, which passed: https://webaim.org/resources/contrastchecker

I didn't update the colour as a result, I only added a comment next to the url formatting function which says the 'blue' is #0000ff and that this passes WCAG AA standards.

…ded comment to clarify in the wrapper function
@addledrabbit addledrabbit linked an issue Oct 20, 2025 that may be closed by this pull request
@ellie-o ellie-o requested a review from Jday7879 October 21, 2025 08:39
Copy link

@Jday7879 Jday7879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code comments make sense to me.
It looks like the branch has been created from main and not dev which is why unit tests are failing. If you merge dev into your branch then update the PR to merge back into dev this should fix things

…k-colour-contrast

Merged dev into feature branch to fix unit tests failing
@addledrabbit
Copy link
Contributor Author

I fetched the latest changes which incorporated #275 , then merged origin/dev, and pushed.

@Jday7879 Jday7879 changed the base branch from main to dev October 22, 2025 06:50
Copy link

@Jday7879 Jday7879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes, I've ran the pre-commit hooks and will merge now :)

@Jday7879 Jday7879 merged commit 437d2a1 into dev Oct 22, 2025
11 of 12 checks passed
@Jday7879 Jday7879 deleted the 280-check-the-hyperlink-colour-contrast branch October 22, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check the hyperlink colour contrast

3 participants