set default value for source.is_cache_enabled column to false
#2133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'd like to focus PRs on one specific problem at a time. Since we're trying to resolve #2131, let's limit our scope to that. There is cases where we have PRs solving multiple issues, but usually there's a common theme (like documentation, typos, etc). In this case, it's a caching setting one one hand and a docker setting on the other. Let's stick with the former, and open an issue about the docker. |
|
The migration version of 2.12.1 is fine. |
|
Sure, I'll keep the PR as-is then. Thanks for the feedback! |
chrisknoll
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2131
Two questions:
should the migration be versioned as v2.12.1 or v2.13.0?
out-of-scope, but while building the container image I noticed the
openjdk:8-jre-slimbase image is deprecated: https://hub.docker.com/_/openjdkI switched to
eclipse-temurin:8-jreand it seems to run fine. Since this PR is just one line so far, should I update the image as well while I'm at it?