remove redundant ToArray

src/NuGetGallery.Core/Auditing/AggregateAuditingService.cs

@@ -43,9 +43,7 @@ public async Task SaveAuditRecordAsync(AuditRecord record)
                 throw new ArgumentNullException(nameof(record));
             }
 
-            var tasks = _services.Select(service => service.SaveAuditRecordAsync(record))
-                                 .ToArray();
-
+            var tasks = _services.Select(service => service.SaveAuditRecordAsync(record));
             await Task.WhenAll(tasks);
         }
     }

src/NuGetGallery.Services/Authentication/AuthenticationService.cs

@@ -715,7 +715,7 @@ public virtual async Task RemoveCredential(User user, Credential cred, bool comm
 
         public virtual async Task EditCredentialScopes(User user, Credential cred, ICollection<Scope> newScopes)
         {
-            foreach (var oldScope in cred.Scopes.ToArray())
+            foreach (var oldScope in cred.Scopes)
             {
                 Entities.Scopes.Remove(oldScope);
             }

src/NuGetGallery.Services/Authentication/Providers/AzureActiveDirectoryV2/AzureActiveDirectoryV2Authenticator.cs

@@ -88,8 +88,7 @@ protected override void AttachToOwinApp(IGalleryConfigurationService config, IAp
                     .Current
                     .AlternateSiteRootList
                     .Split(';')
-                    .Select(d => d.Trim())
-                    .ToArray();
+                    .Select(d => d.Trim());
 
                 _alternateSiteRootList = new HashSet<string>(alternateSiteRootList, StringComparer.OrdinalIgnoreCase);
             }

src/NuGetGallery.Services/Extensions/IEnumerableExtensions.cs

@@ -23,7 +23,7 @@ public static string Flatten(this IEnumerable<string> list)
                 return String.Empty;
             }
 
-            return String.Join(", ", list.ToArray());
+            return String.Join(", ", list);
         }
 
         public static HelperResult Flatten<T>(this IEnumerable<T> items, Func<T, HelperResult> template)
@@ -34,7 +34,7 @@ public static HelperResult Flatten<T>(this IEnumerable<T> items, Func<T, HelperR
             }
             var formattedItems = items.Select(item => template(item).ToHtmlString());
 
-            return new HelperResult(writer => { writer.Write(String.Join(", ", formattedItems.ToArray())); });
+            return new HelperResult(writer => { writer.Write(String.Join(", ", formattedItems)); });
         }
 
         public static bool AnySafe<T>(this IEnumerable<T> items)

src/NuGetGallery.Services/Storage/ContentService.cs

@@ -81,7 +81,7 @@ private async Task<IHtmlString> GetContentItemCore(string name, string[] extensi
                 Trace.Verbose("Cache Expired.");
 
                 // Get the file from the content service
-                var filenames = extensions.Select(extension => name + extension).ToArray();
+                var filenames = extensions.Select(extension => name + extension);
 
                 foreach (var filename in filenames)
                 {

src/NuGetGallery/Areas/Admin/Controllers/ApiKeysController.cs

@@ -53,7 +53,7 @@ public JsonResult Verify(string verifyQuery)
                 return Json(HttpStatusCode.BadRequest, "Invalid empty input!");
             }
 
-            var queries = verifyQuery.Split(new[] { '\r', '\n' }, StringSplitOptions.RemoveEmptyEntries).Select(q => q.Trim()).ToList();
+            var queries = verifyQuery.Split(new[] { '\r', '\n' }, StringSplitOptions.RemoveEmptyEntries).Select(q => q.Trim());
 
             var results = new List<ApiKeyRevokeViewModel>();
             var verifiedApiKey = new HashSet<string>(StringComparer.OrdinalIgnoreCase);