Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant ToArray #9998

Merged
merged 5 commits into from
Jun 25, 2024
Merged

remove redundant ToArray #9998

merged 5 commits into from
Jun 25, 2024

Conversation

SimonCropp
Copy link
Contributor

No description provided.

@SimonCropp SimonCropp requested a review from a team as a code owner June 5, 2024 05:11
@joelverhagen
Copy link
Member

These tests are failing:

NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerAsyncMethod.RemovingNamespaceOwnerRemovesPackageVerified [FAIL] NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerAsyncMethod.MultipleNamespaceOwnersRemovalWorksCorrectly [FAIL]
NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerAsyncMethod.RemovingNamespaceOwnerAsOrganizationAdminRemovesPackageVerified [FAIL] NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerAsyncMethod.AdminCanRemoveAnyOwner [FAIL]
NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerWithMessagesAsyncMethod.RemovingNamespaceOwnerRemovesPackageVerified [FAIL]
NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerWithMessagesAsyncMethod.MultipleNamespaceOwnersRemovalWorksCorrectly [FAIL]
NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerWithMessagesAsyncMethod.RemovingNamespaceOwnerAsOrganizationAdminRemovesPackageVerified [FAIL] NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerWithMessagesAsyncMethod.AdminCanRemoveAnyOwner [FAIL]
NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerWithMessagesAsyncMethod.AllowsNamespaceOwnershipToBeSkipped [FAIL]

Sample error:

    System.InvalidOperationException : Collection was modified; enumeration operation may not execute.
      Stack Trace:
           at System.Collections.Generic.HashSet`1.Enumerator.MoveNext()
           at NuGetGallery.PackageOwnershipManagementService.<RemovePackageOwnerImplAsync>d__19.MoveNext()
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
           at NuGetGallery.PackageOwnershipManagementService.<RemovePackageOwnerAsync>d__18.MoveNext()
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
           at NuGetGallery.PackageOwnershipManagementService.<RemovePackageOwnerAsync>d__17.MoveNext()
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        tests\NuGetGallery.Facts\Services\PackageOwnershipManagementServiceFacts.cs(564,0): at NuGetGallery.PackageOwnershipManagementServiceFacts.TheRemovePackageOwnerAsyncMethod.<RemovePackageOwnerAsync>d__1.MoveNext()
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        tests\NuGetGallery.Facts\Services\PackageOwnershipManagementServiceFacts.cs(669,0): at NuGetGallery.PackageOwnershipManagementServiceFacts.TheRemovePackageOwnerAsyncMethodFacts.<RemovingNamespaceOwnerRemovesPackageVerified>d__8.MoveNext()
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

@SimonCropp
Copy link
Contributor Author

test should be fixed

global.json Outdated Show resolved Hide resolved
This reverts commit b1563ef.
@erdembayar erdembayar merged commit b0f7dc7 into NuGet:dev Jun 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants