Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove authenticode checks for nuget.protocol plugins #6042

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Remove authenticode checks for nuget.protocol plugins #6042

merged 2 commits into from
Oct 15, 2024

Conversation

zivkan
Copy link
Member

@zivkan zivkan commented Sep 21, 2024 •
edited
Loading

Bug

Fixes: https://github.com/NuGet/Client.Engineering/issues/2824

Description

Remove requirement for credential providers to be Authenticode signed on Windows

PR Checklist

@kartheekp-ms kartheekp-ms requested a review from dtivel September 23, 2024 19:34
@aortiz-msft aortiz-msft added the Merge next release PRs that should not be merged until the dev branch targets the next release label Sep 23, 2024
@nkolev92 nkolev92 removed the Merge next release PRs that should not be merged until the dev branch targets the next release label Sep 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Oct 4, 2024
@dotnet-policy-service dotnet-policy-service bot removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Oct 4, 2024
@zivkan zivkan mentioned this pull request Oct 11, 2024
Open
@zivkan zivkan force-pushed the dev-zivkan-protocol-plugins-no-authenticode branch from 1d95dde to ece0b40 Compare October 11, 2024 09:05
@zivkan zivkan marked this pull request as ready for review October 11, 2024 09:05
@zivkan zivkan requested a review from a team as a code owner October 11, 2024 09:05
nkolev92
nkolev92 previously approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a public issue for the breaking change?

dtivel
dtivel previously approved these changes Oct 14, 2024
View reviewed changes
@zivkan zivkan dismissed stale reviews from dtivel and nkolev92 via a890d87 October 15, 2024 00:06
@zivkan zivkan force-pushed the dev-zivkan-protocol-plugins-no-authenticode branch from ece0b40 to a890d87 Compare October 15, 2024 00:06
@zivkan zivkan merged commit 1a8ca60 into dev Oct 15, 2024
29 of 31 checks passed
@zivkan zivkan deleted the dev-zivkan-protocol-plugins-no-authenticode branch October 15, 2024 21:58
@kartheekp-ms kartheekp-ms mentioned this pull request Oct 17, 2024
Merged
3 tasks
@Nigusu-Allehu Nigusu-Allehu mentioned this pull request Oct 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkolev92 nkolev92 nkolev92 approved these changes

@dtivel dtivel dtivel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zivkan @nkolev92 @dtivel @aortiz-msft