Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Lazy initialization from PluginFile.State in PluginFile.cs #13865

Open
Nigusu-Allehu opened this issue Oct 17, 2024 · 0 comments
Labels
Area:Plugin V2 plugin w/ cross platform support Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:DCR Design Change Request

Comments

@Nigusu-Allehu
Copy link
Contributor

The PluginFile class currently uses a Lazy<PluginFileState> for its State property:

public Lazy<PluginFileState> State { get; }

This was originally implemented because we used to perform Authenticode verification on plugins on Windows, which was an expensive operation. The Lazy initialization ensured that this verification was deferred until necessary.

However, since PR #6042 has been merged, we no longer perform Authenticode verification on plugins. Therefore, the Lazy initialization is no longer needed.

@Nigusu-Allehu Nigusu-Allehu added Type:Bug Area:Plugin V2 plugin w/ cross platform support labels Oct 17, 2024
@jebriede jebriede added Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:DCR Design Change Request and removed Type:Bug labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Plugin V2 plugin w/ cross platform support Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:DCR Design Change Request
Projects
None yet
Development

No branches or pull requests

2 participants