Skip to content

Refactor: Move _http_failure to module_status.py - #487

Closed
abhijeetnardele24-hash wants to merge 2 commits into
NovaCode37:mainfrom
abhijeetnardele24-hash:fix/issue-485-http-failure-helper
Closed

abhijeetnardele24-hash wants to merge 2 commits into
NovaCode37:mainfrom
abhijeetnardele24-hash:fix/issue-485-http-failure-helper

Conversation

@abhijeetnardele24-hash

@abhijeetnardele24-hash abhijeetnardele24-hash commented Oct 4, 2026 •

Copy link
Copy Markdown

Closes #485

Changes

  • Moved the duplicate _http_failure helper from cert_transparency.py and wayback.py into a single public annotate_http_failure function in module_status.py.
  • Updated cert_transparency and wayback to use the new shared helper.
  • Added a test in tests/test_module_status.py verifying status code 429, 503 (mapped to RATE_LIMITED) and 500 (mapped to ERROR).
  • Ensured existing tests for these modules pass perfectly.

Copilot AI balanced review requested due to automatic review settings October 4, 2026 08:58
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

Thanks for the first pull request here. CI needs a maintainer to approve the run before it starts, so it may sit for a bit before anything happens. pytest tests/ -q passing is the main thing I look at.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added python Pull requests that update python code javascript Pull requests that update javascript code labels Oct 4, 2026
@abhijeetnardele24-hash
abhijeetnardele24-hash force-pushed the fix/issue-485-http-failure-helper branch from ea56a44 to a8fe28c Compare October 4, 2026 08:59
@NovaCode37

Copy link
Copy Markdown
Owner

Thanks. Two things got mixed together in this branch:

  1. The subnet calculator commit here is the clean version I asked for in fix: translate subnet calculator labels (i18n) #467: hand-added keys, 12 lines per locale, no re-serialized JSON. Please force-push that branch (fix: translate subnet calculator labels) so fix: translate subnet calculator labels (i18n) #467 contains exactly this commit, and I'll merge fix: translate subnet calculator labels (i18n) #467.
  2. Share one HTTP failure helper instead of copying it per module #485 is already taken by fix: share one HTTP failure helper (Closes #485) #486, which was opened about an hour and a half before this one, so I'm keeping it there. Please close this PR once fix: translate subnet calculator labels (i18n) #467 is updated.

@abhijeetnardele24-hash

Copy link
Copy Markdown
Author

I have force-pushed the clean commit to #467 as requested! Closing this PR since #485 was already taken. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share one HTTP failure helper instead of copying it per module

3 participants