Repository navigation
Conversation
|
Thanks for the first pull request here. CI needs a maintainer to approve the run before it starts, so it may sit for a bit before anything happens. |
NovaCode37
left a comment
There was a problem hiding this comment.
Thanks, this is the right shape. One typo breaks it, though: modules/wayback.py imports annotateannotate_http_failure, so importing the module fails and every Wayback lookup with it. It should be annotate_http_failure.
While you're in there, RATE_LIMITED is no longer used in wayback.py or cert_transparency.py after the move, so drop it from both imports. Then it's ready to merge.
NovaCode37
left a comment
There was a problem hiding this comment.
Thanks, this is the right shape. One typo breaks it, though: modules/wayback.py imports annotateannotate_http_failure, so importing the module fails and every Wayback lookup with it. It should be annotate_http_failure.
While you're in there, RATE_LIMITED is no longer used in wayback.py or cert_transparency.py after the move, so drop it from both imports. Then it's ready to merge.
No description provided.