Skip to content

fix: share one HTTP failure helper (Closes #485) - #486

Open
Cid-oe wants to merge 1 commit into
NovaCode37:mainfrom
Cid-oe:fix-485
Open

Cid-oe wants to merge 1 commit into
NovaCode37:mainfrom
Cid-oe:fix-485

Conversation

@Cid-oe

@Cid-oe Cid-oe commented Oct 4, 2026

Copy link
Copy Markdown

No description provided.

@Cid-oe
Cid-oe requested a review from NovaCode37 as a code owner October 4, 2026 07:32
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

Thanks for the first pull request here. CI needs a maintainer to approve the run before it starts, so it may sit for a bit before anything happens. pytest tests/ -q passing is the main thing I look at.

@github-actions github-actions Bot added the python Pull requests that update python code label Oct 4, 2026

@NovaCode37 NovaCode37 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is the right shape. One typo breaks it, though: modules/wayback.py imports annotateannotate_http_failure, so importing the module fails and every Wayback lookup with it. It should be annotate_http_failure.

While you're in there, RATE_LIMITED is no longer used in wayback.py or cert_transparency.py after the move, so drop it from both imports. Then it's ready to merge.

@NovaCode37 NovaCode37 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is the right shape. One typo breaks it, though: modules/wayback.py imports annotateannotate_http_failure, so importing the module fails and every Wayback lookup with it. It should be annotate_http_failure.

While you're in there, RATE_LIMITED is no longer used in wayback.py or cert_transparency.py after the move, so drop it from both imports. Then it's ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants