Bugfix: Reconnection #119
Merged
Bugfix: Reconnection #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philips77
commented
Mar 11, 2025
| @@ -88,7 +88,7 @@ class BlinkyPeripheral: NSObject, CBPeripheralDelegate { | |||
| self.post(.blinkyDidDisconnect(self, error: nil)) | |||
| } | |||
| } | |||
| onConnected { | |||
| _ = onConnected { | |||
There was a problem hiding this comment.
This, and the onStateChange observer never gets dispose. But that's not a big deal, as they should live until the app is killed anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #113.
As stated in #113 (comment), the solution accepted in #102 introduced a bug preventing from reconnecting to a peripheral using native Central Manager. The peripheral instance was removed from managed peripherals on disconnection and reconnection was failing.
In #98 (comment) a different approach was also proposed, where the mock services were cleared. This PR applies this solution, but making them clear on disconnection (before the callback) to match the actual behavior when using a native API.
This seems to fix the reconnection problem.
Additionally, this PR modifies the sample nRF Blinky app adding a button to reconnect to a peripheral after a disconnection. I18n was fixed for displaying disconnections and some error messages.