Reconnection on disconnection when `forceMock == false` does not work due

[nonameplum]

Hey,

The problem is that when the delegate call

centralManager(_:didDisconnectPeripheral:error:)

is handled, we would like to use it to automatically "reconnect" by calling

centralManager.connect(peripheral)

since attempts to connect to a peripheral don’t time out.

But it does not work, as after digging into the issue, the underlying CBPeripherals are stored by the CBMCentralManagerNative which is removed on didDisconnectPeripheral so when connect is called it is blocked the if statement as the peripheral is no longer hold in the dictionary.

Potentially a quick fix could be:

func centralManager(_ central: CBCentralManager,
                    didDisconnectPeripheral peripheral: CBPeripheral,
                    error: Error?) {
    manager.delegate?.centralManager(manager,
                                     didDisconnectPeripheral: getPeripheral(peripheral),
                                     error: error)
    // Check if the error is present otherwise the disconnection was explicit
    if error == nil {
        removePeripheral(peripheral)
    }
}

But I guess, the biggest issue is that CBPeripherals are strongly hold by CBMCentralManagerNative in overall.

[philips77]

Hi,
Thank you for creating the issue. Great catch.
How about first getting the reference to the peripheral, removing it, and calling the delegate:

func centralManager(_ central: CBCentralManager,
                    didDisconnectPeripheral peripheral: CBPeripheral,
                    error: Error?) {
    let p = getPeripheral(peripheral)
    removePeripheral(peripheral)
    manager.delegate?.centralManager(manager,
                                     didDisconnectPeripheral: p,
                                     error: error)
}

Unfortunately, I don't have time to look into it now, but I hope I can get back soon.

[nonameplum]

This way it won't help unfortunately, because connect is called on the central manager later and the same if statement will not allow proceeding as peripheral will be removed from the dictionary at this point.

[philips77]

Right. It should not remove the peripheral, or the connect. I don't remember why it does so. I need to spend some time recalling the project.

[nathandud]

Removing the peripheral was added in #102 in response to #98, in which a peripheral is removed so that it doesn't hold onto all the services/characteristics after a disconnect.

[philips77]

I think I'll clear the services instead of removing the peripheral. Native Central Manager allows to reconnect using the same CBPeripheral instance, it's just a matter of clearing the service cache.

I look into the initial proposal from #98.