Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG fixes: sediment alkalinity and sediment C14 #194

Merged
merged 5 commits into from
Sep 20, 2022
Merged

BUG fixes: sediment alkalinity and sediment C14 #194

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a3ed719
BUG fixes: sediment alkalinity and sediment C14
jmaerz Sep 15, 2022
53f1b1d
add sulf13,14 to reflect code for 12C
jmaerz Sep 19, 2022
f6320c5
Updated also NO3 demand for denitrification
jmaerz Sep 19, 2022
88baae3
fixed 13,14C pore water DIC update
jmaerz Sep 19, 2022
28da4ce
merge with updated beyond-CMIP6 branch to pull in variable sediment p…
jmaerz Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 19 additions & 23 deletions hamocc/powach.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ subroutine powach(kpie,kpje,kpke,kbnd,prho,omask,psao,lspin)
use mo_carbch, only: co3,keqb,ocetra,sedfluxo
use mo_chemcon, only: calcon
use mo_sedmnt, only: porwat,porsol,powtra,produs,prcaca,prorca,rno3,seddw,sedhpl,sedlay,silpro
use mo_biomod, only: rnit,ro2ut
use mo_biomod, only: rnit,ro2ut,rcar,rdnit1,rdnit2
use mo_control_bgc, only: dtbgc
use mo_param1_bgc, only: ioxygen,ipowaal,ipowaic,ipowaox,ipowaph,ipowasi,ipown2,ipowno3,isilica,isssc12,issso12,issssil, &
& issster, ks
Expand All @@ -87,10 +87,10 @@ subroutine powach(kpie,kpje,kpke,kbnd,prho,omask,psao,lspin)

real :: sedb1(kpie,0:ks),sediso(kpie,0:ks)
real :: solrat(kpie,ks),powcar(kpie,ks)
real :: aerob(kpie,ks),anaerob(kpie,ks)
real :: aerob(kpie,ks),anaerob(kpie,ks),sulf(kpie,ks)
#ifdef cisonew
real :: aerob13(kpie,ks),anaerob13(kpie,ks)
real :: aerob14(kpie,ks),anaerob14(kpie,ks)
real :: aerob13(kpie,ks),anaerob13(kpie,ks),sulf13(kpie,ks)
real :: aerob14(kpie,ks),anaerob14(kpie,ks),sulf14(kpie,ks)
#endif
real :: disso, dissot, undsa, silsat, posol
real :: umfa, denit, saln, rrho, alk, c, sit, pt
Expand Down Expand Up @@ -132,11 +132,14 @@ subroutine powach(kpie,kpje,kpke,kbnd,prho,omask,psao,lspin)
powcar(i,k) = 0.
anaerob(i,k)= 0.
aerob(i,k) = 0.
sulf(i,k) = 0.
#ifdef cisonew
anaerob13(i,k)=0.
aerob13(i,k) =0.
sulf13(i,k) =0.
anaerob14(i,k)=0.
aerob14(i,k) =0.
sulf14(i,k) =0.
#endif
enddo
enddo
Expand Down Expand Up @@ -334,9 +337,6 @@ subroutine powach(kpie,kpje,kpke,kbnd,prho,omask,psao,lspin)
#ifdef cisonew
sedlay(i,j,k,issso13) = sedlay(i,j,k,issso13) - poso13
sedlay(i,j,k,issso14) = sedlay(i,j,k,issso14) - poso14
! is this correct? no correspondance in the lines above
powtra(i,j,k,ipowc13) = powtra(i,j,k,ipowc13) + poso13*umfa
powtra(i,j,k,ipowc14) = powtra(i,j,k,ipowc14) + poso14*umfa
#endif
endif
enddo
Expand All @@ -354,7 +354,7 @@ subroutine powach(kpie,kpje,kpke,kbnd,prho,omask,psao,lspin)
do i = 1, kpie
if(omask(i,j) > 0.5) then
if(powtra(i,j,k,ipowaox) < 1.e-6) then
posol = denit * MIN(0.5*powtra(i,j,k,ipowno3)/114., &
posol = denit * MIN(0.25*powtra(i,j,k,ipowno3)/rdnit2, &
& sedlay(i,j,k,issso12))
umfa = porsol(k)/porwat(k)
anaerob(i,k) = posol*umfa !this has P units: kmol P/m3 of pore water
Expand All @@ -368,14 +368,11 @@ subroutine powach(kpie,kpje,kpke,kbnd,prho,omask,psao,lspin)
#endif
sedlay(i,j,k,issso12) = sedlay(i,j,k,issso12) - posol
powtra(i,j,k,ipowaph) = powtra(i,j,k,ipowaph) + posol*umfa
powtra(i,j,k,ipowno3) = powtra(i,j,k,ipowno3) - 98.*posol*umfa
powtra(i,j,k,ipown2) = powtra(i,j,k,ipown2) + 57.*posol*umfa
powtra(i,j,k,ipowno3) = powtra(i,j,k,ipowno3) - rdnit1*posol*umfa
powtra(i,j,k,ipown2) = powtra(i,j,k,ipown2) + rdnit2*posol*umfa
#ifdef cisonew
sedlay(i,j,k,issso13) = sedlay(i,j,k,issso13) - poso13
sedlay(i,j,k,issso14) = sedlay(i,j,k,issso14) - poso14
! is this correct? no corresponance in the lines above
powtra(i,j,k,ipowc13) = powtra(i,j,k,ipowc13) + poso13*umfa
powtra(i,j,k,ipowc14) = powtra(i,j,k,ipowc14) + poso14*umfa
#endif
endif
endif
Expand All @@ -390,15 +387,14 @@ subroutine powach(kpie,kpje,kpke,kbnd,prho,omask,psao,lspin)
if(powtra(i,j,k,ipowaox) < 3.e-6 .and. powtra(i,j,k,ipowno3) < 3.e-6) then
posol = denit * sedlay(i,j,k,issso12) ! remineralization of poc
umfa = porsol(k) / porwat(k)
!this overwrites anaerob from denitrification. added =anaerob+..., works
anaerob(i,k) = anaerob(i,k) + posol*umfa !this has P units: kmol P/m3 of pore water
sulf(i,k) = posol*umfa !this has P units: kmol P/m3 of pore water
#ifdef cisonew
rato13 = sedlay(i,j,k,issso13) / (sedlay(i,j,k,issso12)+safediv)
rato14 = sedlay(i,j,k,issso14) / (sedlay(i,j,k,issso12)+safediv)
poso13 = posol * rato13
poso14 = posol * rato14
anaerob13(i,k) = anaerob13(i,k) + poso13*umfa !this has P units: kmol P/m3 of pore water
anaerob14(i,k) = anaerob13(i,k) + poso14*umfa !this has P units: kmol P/m3 of pore water
sulf13(i,k) = poso13*umfa !this has P units: kmol P/m3 of pore water
sulf14(i,k) = poso14*umfa !this has P units: kmol P/m3 of pore water
#endif
sedlay(i,j,k,issso12) = sedlay(i,j,k,issso12) - posol
powtra(i,j,k,ipowaph) = powtra(i,j,k,ipowaph) + posol*umfa
Expand Down Expand Up @@ -426,8 +422,8 @@ subroutine powach(kpie,kpje,kpke,kbnd,prho,omask,psao,lspin)
if(omask(i,j) > 0.5) then
saln= min( 40., max( 0., psao(i,j,kbo(i,j))))
rrho= prho(i,j,kbo(i,j))
alk = (powtra(i,j,k,ipowaal) - (anaerob(i,k)+aerob(i,k))*16.) / rrho
c = (powtra(i,j,k,ipowaic) + (anaerob(i,k)+aerob(i,k))*122.) / rrho
alk = (powtra(i,j,k,ipowaal) - (sulf(i,k)+aerob(i,k))*(rnit+1.) + anaerob(i,k)*(rdnit1-1.)) / rrho
c = (powtra(i,j,k,ipowaic) + (anaerob(i,k)+aerob(i,k)+sulf(i,k))*rcar) / rrho
sit = powtra(i,j,k,ipowasi) / rrho
pt = powtra(i,j,k,ipowaph) / rrho
ah1 = sedhpl(i,j,k)
Expand Down Expand Up @@ -535,16 +531,16 @@ subroutine powach(kpie,kpje,kpke,kbnd,prho,omask,psao,lspin)
#endif
sedlay(i,j,k,isssc12) = sedlay(i,j,k,isssc12) - posol
powtra(i,j,k,ipowaic) = powtra(i,j,k,ipowaic) &
& + posol * umfa + (aerob(i,k) + anaerob(i,k)) * 122.
& + posol * umfa + (aerob(i,k) + anaerob(i,k) + sulf(i,k)) * rcar
powtra(i,j,k,ipowaal) = powtra(i,j,k,ipowaal) &
& + 2. * posol * umfa - 16. * (aerob(i,k) + anaerob(i,k))
& + 2. * posol * umfa - (rnit+1.)*(aerob(i,k) + sulf(i,k)) + (rdnit1-1.)*anaerob(i,k)
#ifdef cisonew
sedlay(i,j,k,isssc13) = sedlay(i,j,k,isssc13) - poso13
sedlay(i,j,k,isssc14) = sedlay(i,j,k,isssc14) - poso14
powtra(i,j,k,ipowc13) = powtra(i,j,k,ipowc13) + poso13 * umfa &
& + (aerob13(i,k) + anaerob13(i,k)) * 122.
& + (aerob13(i,k) + anaerob13(i,k) + sulf13(i,k)) * rcar
powtra(i,j,k,ipowc14) = powtra(i,j,k,ipowc14) + poso14 * umfa &
& + (aerob14(i,k) + anaerob14(i,k)) * 122.
& + (aerob14(i,k) + anaerob14(i,k) + sulf14(i,k)) * rcar
#endif
endif
enddo
Expand Down