-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG fixes: sediment alkalinity and sediment C14 #194
BUG fixes: sediment alkalinity and sediment C14 #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me (I trust that this is now consistent with the water column code - I haven't checked this myself). Regarding the isotope part: it would be good to aim for a version of the code that runs with C-isotopes in the sediment enabled (wasn't done so far). Therefore I would vote for including sulf13/14 in this fix.
Hi @JorgSchwinger , the |
Ok, I see. For the C-isotope code, the philosophy was to reflect every relevant line in the C12 code by one corresponding line in the C13/14 code. So I agree, I would also be in favor of introducing sulf13/14 even if it's not strictly necessary. |
Ok, thanks for that feedback and valuable information! I'll take care of it beginning of next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, no complaints from my side
Bug fixes for denitrification stoichiometry and C-isotopes in the sediment
Dear @TomasTorsvik and @JorgSchwinger , I herewith open the pull request linked to issue #193. In addition to the described alkalinity issue, it seemed to me that there was an additional bugfix for C14 needed - please re-check carefully. This branch hasn't been checked on betzy yet, but compiled successfully locally. I left the rest of the isotopes untouched (didn't introduce
sulf13
andsulf14
, respectively, since it wasn't needed from a bug fixing perspective, while it breakes the consistency betweenanaerob
and e.g.anaerob13
). If you wish to introducesul13,14
for more consistency, let me know. closes #193