Lon-lat variable sediment porosity #189

jmaerz · 2022-09-02T11:27:00Z

This feature branch enables to read a sediment porosity file as input for the sediment compartment of iHAMOCC. iHAMOCC then considers the spatially variable porosity through the scaling of the sediment pore water diffusion coefficients and in sediment processes. This feature can thus far only be switched on via the namelist switch l_sed_por for expert users (current default is .false.).

The reading of a sediment porosity file is thus far untested (and will produce results different from CMIP6), while the current default version with l_sed_por=.false. produces bit identical results compared to the former master branch. I am working on the input file for this feature, but wanted to give you already the possibility to review the code changes.

…sity

… hard-coded in powach

…ediment porosity

jmaerz · 2022-09-02T11:44:13Z

Ok, I just realize that the commit comes with all changes done in master over the past days (as compared to this development branch). Maybe it would be good to first merge the master into the development branch?

TomasTorsvik · 2022-09-02T14:00:12Z

Ok, I just realize that the commit comes with all changes done in master over the past days (as compared to this development branch). Maybe it would be good to first merge the master into the development branch?

Yes, probably that is a good idea, although this will create an additional merge commit on the development branch. Don't know if there is any better alternative though.

UPDATE: I created a PR for merging master to feature-hamocc_beyond-CMIP6 #190

JorgSchwinger · 2022-09-03T20:57:01Z

I'll wait with my review until #190 has been merged...

jmaerz · 2022-09-05T08:39:55Z

Hi @JorgSchwinger and @TomasTorsvik , I briefly discussed with @TomasTorsvik about the history issue and tested out, whether an initial merge with the feature-hamocc_beyond-CMIP6 branch would solve the history issue (it does). Given our common agreement on still merging features into master that do not break backward compatibility, I am now moving the pull request to the master branch. I will check again with regards to the loop order (thanks @JorgSchwinger).

TomasTorsvik

This looks fine to me. I wonder if we should use the opportunity to clean up some of the comments that seem outdated.

TomasTorsvik · 2022-09-05T09:46:54Z

hamocc/mo_sedmnt.F90

+      !REAL, save :: porsol(ks)  = 0.0
+      !REAL, save :: porwah(ks)  = 0.0
+      !REAL, save :: porwat(ks)  = 0.0


Maybe these lines should be deleted instead of commented out? With the modified code theses lines can not be re-enabled by un-commenting.

Right. I missed to clean that. I'll do this.

TomasTorsvik · 2022-09-05T09:56:41Z

hamocc/bodensed.F90

+  ! Dissolution rate constant of opal (disso) [1/(kmol Si(OH)4/m3)*1/sec]
+  ! THIS NEEDS TO BE CHANGED TO disso=3.e-8! THIS IS ONLY KEPT FOR THE MOMENT
+  ! FOR BACKWARDS COMPATIBILITY
+  !disso=3.e-8  ! (2011-01-04) EMR
+  !disso=1.e-6 ! test vom 03.03.04 half live sil ca. 20.000 yr 
+  disso_sil = 1.e-6*dtbgc


Suggested change

! Dissolution rate constant of opal (disso) [1/(kmol Si(OH)4/m3)*1/sec]

! THIS NEEDS TO BE CHANGED TO disso=3.e-8! THIS IS ONLY KEPT FOR THE MOMENT

! FOR BACKWARDS COMPATIBILITY

!disso=3.e-8 ! (2011-01-04) EMR

!disso=1.e-6 ! test vom 03.03.04 half live sil ca. 20.000 yr

disso_sil = 1.e-6*dtbgc

! Dissolution rate constant of opal (disso) [1/(kmol Si(OH)4/m3)*1/sec]

! THIS NEEDS TO BE CHANGED TO disso=3.e-8! THIS IS ONLY KEPT FOR THE MOMENT

! FOR BACKWARDS COMPATIBILITY

!disso_sil = 3.e-8*dtbgc ! (2011-01-04) EMR

!disso_sil = 1.e-6*dtbgc ! test vom 03.03.04 half live sil ca. 20.000 yr

disso_sil = 1.e-6*dtbgc

Maybe a bit pedantic, but I think it is best if the commented lines also reflect the code change.

Correct, I can do this.

TomasTorsvik · 2022-09-05T10:02:08Z

hamocc/bodensed.F90

  enddo
+
+  sedict = 1.e-9 * dtbgc ! Moecular diffusion coefficient


Suggested change

sedict = 1.e-9 * dtbgc ! Moecular diffusion coefficient

sedict = 1.e-9 * dtbgc ! Molecular diffusion coefficient

typo

TomasTorsvik · 2022-09-05T10:06:00Z

hamocc/bodensed.F90

+  silsat    = 0.001
+
+  ! Degradation rate constant of POP (disso) [1/(kmol O2/m3)*1/sec]
+  disso_poc = 0.01 / 86400. * dtbgc  !  disso=3.e-5 was quite high


Suggested change

disso_poc = 0.01 / 86400. * dtbgc ! disso=3.e-5 was quite high

disso_poc = 0.01 / 86400. * dtbgc

Is this comment relevant, do we need to keep it around?

I can't tell - maybe @JorgSchwinger made some experiences that allow for better judgement?

TomasTorsvik · 2022-09-05T10:07:06Z

hamocc/bodensed.F90


-  sedict = 1.e-9 * dtbgc
+  ! Denitrification rate constant of POP (disso) [1/sec]
+  sed_denit =  0.01/86400. * dtbgc !ik      denit = 1.e-6*dtbgc


Suggested change

sed_denit = 0.01/86400. * dtbgc !ik denit = 1.e-6*dtbgc

sed_denit = 0.01/86400. * dtbgc

Same as above

@JorgSchwinger - any reason to keep the comment?

No, I don't think so, too.

TomasTorsvik · 2022-09-05T10:08:51Z

hamocc/sedshi.F90

@@ -219,7 +219,7 @@ SUBROUTINE SEDSHI(kpie,kpje,omask)

 ! fill the last active layer
        refill=seddef/(buried+1.e-10) 
-        frac = porsol(ks)*seddw(ks) !changed k to ks, ik
+        frac = porsol(i,j,ks)*seddw(ks) !changed k to ks, ik


Suggested change

frac = porsol(i,j,ks)*seddw(ks) !changed k to ks, ik

frac = porsol(i,j,ks)*seddw(ks)

another comment that doesn't seem to add much info

I can delete it, sure.

JorgSchwinger · 2022-09-15T11:18:43Z

cime_config/buildnml

@@ -237,6 +237,9 @@ set OALKSCEN = "''"
 set OALKFILE = "''"
 set WITH_DMSPH = .false.
 set PI_PH_FILE = "''"
+set L_SED_POR = .false.


Maybe a more suggestive name would be preferable? For example L_SEDPOR_2D to indicate that this activates a 2d-spatially variable sediment porosity?

I agree. Thanks for the suggestion! Maybe l_3Dvarsedpor (variable sediment porosity)?!

JorgSchwinger · 2022-09-15T11:24:30Z

cime_config/buildnml

@@ -1470,6 +1479,8 @@ cat >>! $RUNDIR/ocn_in$inststr << EOF
  INID14C      = $INID14C
  WITH_DMSPH   = $WITH_DMSPH
  PI_PH_FILE   = $PI_PH_FILE
+  L_SED_POR    = $L_SED_POR
+  SEDPORFILE   = $SEDPORFILE
 /



GitHub won't let me add a comment in an untouched part of the code, but further below at line 1840 there is a file blom.input_data_list created. If L_SED_POR is activated and SEDPORFILE specified, the filename should be added to this file (used by the CESM scripting system to check at submission whether all files are available)

I see. Thanks for the explanation! I'll add that.

JorgSchwinger · 2022-09-15T11:42:02Z

hamocc/bodensed.F90

+  ! this initialization can be done later via reading a porosity map
+  if (l_sed_por)then
+   ! lon-lat variable sediment porosity from input file
+   call apply_sedpor(kpie,kpje,ks,omask,sed_por)


I find it a bit overkill to define an extra module for ~10 lines of code (essentially porwat=sedpor) that could be just placed directly here.

:-) - agree - I was debating with myself - I'll change it.

JorgSchwinger · 2022-09-15T11:52:40Z

hamocc/mo_read_sedpor.F90

+
+contains
+
+subroutine ini_read_sedpor(kpie,kpje,ks,omask)


Actually, there is no need to allocate the array sed_por permanently: The array is only needed to transfer the data from this routine to bodensed (both called from hamocc_ini). So one could define sed_por as a local (automatic) array in hamocc_ini, pass it first to read_sedpor and then to bodensed. On return from hamocc_ini, sed_por will be automatically deallocated. I would then also rename this routine to read_sedpor because then there is nothing that is really initialised (this would be more consistent with the fact that this is a one time read operation, not something that is used later on).

On a side note, one could integrate bodensed into mo_sedmnt and rename it to ini_sedmnt, which would make more sense than having it as a stand-alone subroutine. Maybe something for later.

Hi @JorgSchwinger , I am doing the first paragraph. With respect to the second part: I like the idea, was shortly about to do it already before. I would like to do this as another pull request, though, to minimize conflicts with my own developments. I'll move the subroutine soon.

rename switch, application directly in bodensed, read porosity file to non-permanent sed_por

jmaerz · 2022-09-15T13:20:44Z

Hi @JorgSchwinger and @TomasTorsvik , I adjusted the code wrt to Jörgs comments and merged with current master to resolve upcoming conflicts (due to previous changes to the powtra -> ocetra mapping). The only thing I haven't changed thus far is the comment from Tomas: #189 (comment) which just concerns a comment in the code. Do you want to re-review the pull request or shall I merge into master?

TomasTorsvik · 2022-09-15T13:26:54Z

The only thing I haven't changed thus far is the comment from Tomas: #189 (comment) which just concerns a comment in the code.

The comment is not essential. From my point of view you can merge it as it is into master.

JorgSchwinger · 2022-09-15T14:20:39Z

Yes, I agree, please go ahead

Introducing a static 3D sediment porosity field that can be optionally read in with effects on molecular pore water diffusion and shifting.

* Dynamic mapping of pore water tracers to ocean tracers (#192) * Initial restructuring of sediment-related tracer declaration and initialization * Introducing mapping function * Remove unncessary comments * Fixed diagnostics bug and updated index naming * Added initial support for NUOPC driver. * Lon-lat variable sediment porosity (#189) Introducing a static 3D sediment porosity field that can be optionally read in with effects on molecular pore water diffusion and shifting. * Added wave forcing fields. * Renamed folder for MCT driver. * Moved MCT specific file from drivers/cpl_share/ to drivers/mct/. * Rename drivers/mct/mod_swtfrz.F to drivers/mct/mod_swtfrz.F90. * Rewrite to drivers/mct/mod_swtfrz.F90 to free format Fortran. * Remove redundant definition of kOBL. * Redefine kOBL, cast as integer * Fixing variable sediment porosity - field initialization in case of `sedbypass=true` (#198) * Removing bodensed - Initialization of sediment parameters and fields now in mo_sedmnt * Hamocc hybrid coord2 (#179) Make the surface mixed layer depth fractional index `hOBL` available for use in iHAMOCC, and adjust the internal iHAMOCC index `kmle` according to `hOBL`. Default value `kmle = 2` is retained for consistency with isopycnic coordinates. * Fix porosity read (#201) * Fixing the reading of variable porosity input field in preparation for the NorESM 2.0.6 release Cherry-picked from private Ncycleprivate branch 0d56930e2fdd62caba964d375b57304942568926 * Provide number of layers (3rd dim) via ks and not hard-coded * minor clean-up * Correct unit of diagnostic variable dp_trc. * Made conservation and checksum diagnostics selectable by namelist options (default off). * pCO2, Piston velocity and solubility output (#202) * add pCO2m (moist), CO2 piston velocity and solubility output - caution: kwco2 piston velocity now really holds only piston velocity (and not times solubility) * Bugfix pnetcdf (#208) * Add variables used by PNETCDF to explicit use staements. * Move implicit none statments * update explicit use statement for pnetcdf * fixed units and renamed calcium burial to CaCO3 burial (#212) Fixed sediment clay units. * Add option for surface pH output (#221) * Remove unused parameters in wrt* subroutine calls in ncout_hamocc.F90 * Import get_bgc_namelist only in subroutine where it is needed. (#225) Co-authored-by: Mats Bentsen <mben@norceresearch.no> Co-authored-by: Tomas Torsvik <tomas.torsvik.work@gmail.com> Co-authored-by: Tomas Torsvik <43031053+TomasTorsvik@users.noreply.github.com> Co-authored-by: Jörg Schwinger <jorg.schwinger@norceresearch.no>

* Dynamic mapping of pore water tracers to ocean tracers (#192) * Initial restructuring of sediment-related tracer declaration and initialization * Introducing mapping function * Remove unncessary comments * Fixed diagnostics bug and updated index naming * Added initial support for NUOPC driver. * Lon-lat variable sediment porosity (#189) Introducing a static 3D sediment porosity field that can be optionally read in with effects on molecular pore water diffusion and shifting. * Added wave forcing fields. * Renamed folder for MCT driver. * Moved MCT specific file from drivers/cpl_share/ to drivers/mct/. * Rename drivers/mct/mod_swtfrz.F to drivers/mct/mod_swtfrz.F90. * Rewrite to drivers/mct/mod_swtfrz.F90 to free format Fortran. * Remove redundant definition of kOBL. * Redefine kOBL, cast as integer * Fixing variable sediment porosity - field initialization in case of `sedbypass=true` (#198) * Removing bodensed - Initialization of sediment parameters and fields now in mo_sedmnt * This is the first commit of MKS units. All variables in the subroutines have been converted to MKS [meter, kg, seconds] instead of CGS [cm, gram, seconds] with necessary coefficients. The default option which is CGS reproduce old results. The new option MKS cannot reproduce because of machine precision. * Hamocc hybrid coord2 (#179) Make the surface mixed layer depth fractional index `hOBL` available for use in iHAMOCC, and adjust the internal iHAMOCC index `kmle` according to `hOBL`. Default value `kmle = 2` is retained for consistency with isopycnic coordinates. * BLOM CIME cpp updates to run in NorESM * bug fixes for the CGS MKS conversion * cesm thermal forcing bug fixes for reproducibility * BLOM MKS update to export winds into the CESM using proper units. * input values in ocn_in case is updated for mks setup * default cgsmks value changed * Initialize some variables in the k-epsilon model. * Fix porosity read (#201) * Fixing the reading of variable porosity input field in preparation for the NorESM 2.0.6 release Cherry-picked from private Ncycleprivate branch 0d56930e2fdd62caba964d375b57304942568926 * Provide number of layers (3rd dim) via ks and not hard-coded * minor clean-up * Correct unit of diagnostic variable dp_trc. * Made conservation and checksum diagnostics selectable by namelist options (default off). * pCO2, Piston velocity and solubility output (#202) * add pCO2m (moist), CO2 piston velocity and solubility output - caution: kwco2 piston velocity now really holds only piston velocity (and not times solubility) * Bugfix pnetcdf (#208) * Add variables used by PNETCDF to explicit use staements. * Move implicit none statments * update explicit use statement for pnetcdf * fixed units and renamed calcium burial to CaCO3 burial (#212) Fixed sediment clay units. * - Made the "fuk95" configuration work with MKS units. - Removed "CGS" CPP flag. - Changed some unit conversion factors from variables to parameters. - Introduced rho0 (= 1/alpha0) parameter. - Updated copyright statements. * Correct unit conversion of mixed layer depth to pressure. * Updated NorESM coupling scripts for the use of MKS units. * Fixed check of unit system when building as NorESM component. * Add option for surface pH output (#221) * Remove unused parameters in wrt* subroutine calls in ncout_hamocc.F90 * Import get_bgc_namelist only in subroutine where it is needed. (#225) * fix missing ' (#228) Fixing a missing ' that only showed up when using `cisonew` --------- Co-authored-by: Mats Bentsen <mben@norceresearch.no> Co-authored-by: Tomas Torsvik <tomas.torsvik.work@gmail.com> Co-authored-by: Mehmet Ilicak <milicak@itu.edu.tr> Co-authored-by: Tomas Torsvik <43031053+TomasTorsvik@users.noreply.github.com> Co-authored-by: Jörg Schwinger <jorg.schwinger@norceresearch.no>

Introducing a static 3D sediment porosity field that can be optionally read in with effects on molecular pore water diffusion and shifting.

* Dynamic mapping of pore water tracers to ocean tracers (NorESMhub#192) * Initial restructuring of sediment-related tracer declaration and initialization * Introducing mapping function * Remove unncessary comments * Fixed diagnostics bug and updated index naming * Added initial support for NUOPC driver. * Lon-lat variable sediment porosity (NorESMhub#189) Introducing a static 3D sediment porosity field that can be optionally read in with effects on molecular pore water diffusion and shifting. * Added wave forcing fields. * Renamed folder for MCT driver. * Moved MCT specific file from drivers/cpl_share/ to drivers/mct/. * Rename drivers/mct/mod_swtfrz.F to drivers/mct/mod_swtfrz.F90. * Rewrite to drivers/mct/mod_swtfrz.F90 to free format Fortran. * Remove redundant definition of kOBL. * Redefine kOBL, cast as integer * Fixing variable sediment porosity - field initialization in case of `sedbypass=true` (NorESMhub#198) * Removing bodensed - Initialization of sediment parameters and fields now in mo_sedmnt * Hamocc hybrid coord2 (NorESMhub#179) Make the surface mixed layer depth fractional index `hOBL` available for use in iHAMOCC, and adjust the internal iHAMOCC index `kmle` according to `hOBL`. Default value `kmle = 2` is retained for consistency with isopycnic coordinates. * Fix porosity read (NorESMhub#201) * Fixing the reading of variable porosity input field in preparation for the NorESM 2.0.6 release Cherry-picked from private Ncycleprivate branch 0d56930e2fdd62caba964d375b57304942568926 * Provide number of layers (3rd dim) via ks and not hard-coded * minor clean-up * Correct unit of diagnostic variable dp_trc. * Made conservation and checksum diagnostics selectable by namelist options (default off). * pCO2, Piston velocity and solubility output (NorESMhub#202) * add pCO2m (moist), CO2 piston velocity and solubility output - caution: kwco2 piston velocity now really holds only piston velocity (and not times solubility) * Bugfix pnetcdf (NorESMhub#208) * Add variables used by PNETCDF to explicit use staements. * Move implicit none statments * update explicit use statement for pnetcdf * fixed units and renamed calcium burial to CaCO3 burial (NorESMhub#212) Fixed sediment clay units. * Add option for surface pH output (NorESMhub#221) * Remove unused parameters in wrt* subroutine calls in ncout_hamocc.F90 * Import get_bgc_namelist only in subroutine where it is needed. (NorESMhub#225) Co-authored-by: Mats Bentsen <mben@norceresearch.no> Co-authored-by: Tomas Torsvik <tomas.torsvik.work@gmail.com> Co-authored-by: Tomas Torsvik <43031053+TomasTorsvik@users.noreply.github.com> Co-authored-by: Jörg Schwinger <jorg.schwinger@norceresearch.no>

…b#232) * Dynamic mapping of pore water tracers to ocean tracers (NorESMhub#192) * Initial restructuring of sediment-related tracer declaration and initialization * Introducing mapping function * Remove unncessary comments * Fixed diagnostics bug and updated index naming * Added initial support for NUOPC driver. * Lon-lat variable sediment porosity (NorESMhub#189) Introducing a static 3D sediment porosity field that can be optionally read in with effects on molecular pore water diffusion and shifting. * Added wave forcing fields. * Renamed folder for MCT driver. * Moved MCT specific file from drivers/cpl_share/ to drivers/mct/. * Rename drivers/mct/mod_swtfrz.F to drivers/mct/mod_swtfrz.F90. * Rewrite to drivers/mct/mod_swtfrz.F90 to free format Fortran. * Remove redundant definition of kOBL. * Redefine kOBL, cast as integer * Fixing variable sediment porosity - field initialization in case of `sedbypass=true` (NorESMhub#198) * Removing bodensed - Initialization of sediment parameters and fields now in mo_sedmnt * This is the first commit of MKS units. All variables in the subroutines have been converted to MKS [meter, kg, seconds] instead of CGS [cm, gram, seconds] with necessary coefficients. The default option which is CGS reproduce old results. The new option MKS cannot reproduce because of machine precision. * Hamocc hybrid coord2 (NorESMhub#179) Make the surface mixed layer depth fractional index `hOBL` available for use in iHAMOCC, and adjust the internal iHAMOCC index `kmle` according to `hOBL`. Default value `kmle = 2` is retained for consistency with isopycnic coordinates. * BLOM CIME cpp updates to run in NorESM * bug fixes for the CGS MKS conversion * cesm thermal forcing bug fixes for reproducibility * BLOM MKS update to export winds into the CESM using proper units. * input values in ocn_in case is updated for mks setup * default cgsmks value changed * Initialize some variables in the k-epsilon model. * Fix porosity read (NorESMhub#201) * Fixing the reading of variable porosity input field in preparation for the NorESM 2.0.6 release Cherry-picked from private Ncycleprivate branch 0d56930e2fdd62caba964d375b57304942568926 * Provide number of layers (3rd dim) via ks and not hard-coded * minor clean-up * Correct unit of diagnostic variable dp_trc. * Made conservation and checksum diagnostics selectable by namelist options (default off). * pCO2, Piston velocity and solubility output (NorESMhub#202) * add pCO2m (moist), CO2 piston velocity and solubility output - caution: kwco2 piston velocity now really holds only piston velocity (and not times solubility) * Bugfix pnetcdf (NorESMhub#208) * Add variables used by PNETCDF to explicit use staements. * Move implicit none statments * update explicit use statement for pnetcdf * fixed units and renamed calcium burial to CaCO3 burial (NorESMhub#212) Fixed sediment clay units. * - Made the "fuk95" configuration work with MKS units. - Removed "CGS" CPP flag. - Changed some unit conversion factors from variables to parameters. - Introduced rho0 (= 1/alpha0) parameter. - Updated copyright statements. * Correct unit conversion of mixed layer depth to pressure. * Updated NorESM coupling scripts for the use of MKS units. * Fixed check of unit system when building as NorESM component. * Add option for surface pH output (NorESMhub#221) * Remove unused parameters in wrt* subroutine calls in ncout_hamocc.F90 * Import get_bgc_namelist only in subroutine where it is needed. (NorESMhub#225) * fix missing ' (NorESMhub#228) Fixing a missing ' that only showed up when using `cisonew` --------- Co-authored-by: Mats Bentsen <mben@norceresearch.no> Co-authored-by: Tomas Torsvik <tomas.torsvik.work@gmail.com> Co-authored-by: Mehmet Ilicak <milicak@itu.edu.tr> Co-authored-by: Tomas Torsvik <43031053+TomasTorsvik@users.noreply.github.com> Co-authored-by: Jörg Schwinger <jorg.schwinger@norceresearch.no>

jmaerz added 16 commits August 30, 2022 15:39

ADD oafx to meson

cb2ddf8

Declaring and allocating 3-D fields for porsol, porwah, porwat

21aa70d

Introducing 2D field for total solid sediment volume: solfu

61e0cec

Initializing 2D and 3D fields for sediment

654b6d5

deleted real solfu, since it became an array

0198811

exchange k by i,j,k for porwat,porsol,porwah

3f35c6b

make sediment diffusion coeff spatially (lon,lat,z) dependent of poro…

55948dd

…sity

merge with fixed oafx branch

96311dc

fix import of zcoefsu

2fedbd9

fields to 3D

afc9628

to 3D and account for lon-lat inhomogeneous porosity

6cb54ab

to 2D / 3D

9623c12

1D -> 3D

f98bb5a

Initialize parameters for dissolution/remin already in bodensed - not…

fe7788c

… hard-coded in powach

some clean-up

a3366dc

Introduce potential for reading and application of lon-lat variable s…

86ff2c8

…ediment porosity

jmaerz requested review from JorgSchwinger and TomasTorsvik September 2, 2022 11:27

merge with master - fixed oafx

cbab888

jmaerz changed the base branch from feature-hamocc_beyond-CMIP6 to master September 5, 2022 08:40

changed loop order in touched loops, where possible

9e60515

TomasTorsvik approved these changes Sep 5, 2022

View reviewed changes

Minor changes to meet some review comments

978a95b

jmaerz added enhancement New feature or request iHAMOCC Issue mainly concerns the iHAMOCC code base labels Sep 6, 2022

jmaerz self-assigned this Sep 6, 2022

JorgSchwinger reviewed Sep 15, 2022

View reviewed changes

JorgSchwinger approved these changes Sep 15, 2022

View reviewed changes

jmaerz added 3 commits September 15, 2022 14:45

Response to reviews

e44c152

rename switch, application directly in bodensed, read porosity file to non-permanent sed_por

merge with master

dce4263

removed comment in sedshi.F90

1a7e6ec

jmaerz merged commit 88d6208 into NorESMhub:master Sep 15, 2022

jmaerz mentioned this pull request Nov 8, 2022

Fix porosity read #201

Merged

TomasTorsvik mentioned this pull request Nov 30, 2022

Potential bug in sedshi.F90 #210

Closed

jmaerz added a commit to jmaerz/BLOM that referenced this pull request Aug 9, 2023

Lon-lat variable sediment porosity (NorESMhub#189)

f60e840

Introducing a static 3D sediment porosity field that can be optionally read in with effects on molecular pore water diffusion and shifting.

jmaerz added a commit to jmaerz/BLOM that referenced this pull request Aug 9, 2023

Lon-lat variable sediment porosity (NorESMhub#189)

1742ed6

Introducing a static 3D sediment porosity field that can be optionally read in with effects on molecular pore water diffusion and shifting.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lon-lat variable sediment porosity #189

Lon-lat variable sediment porosity #189

jmaerz commented Sep 2, 2022

jmaerz commented Sep 2, 2022

TomasTorsvik commented Sep 2, 2022 •

edited

Loading

JorgSchwinger commented Sep 3, 2022

jmaerz commented Sep 5, 2022 •

edited

Loading

TomasTorsvik left a comment

TomasTorsvik Sep 5, 2022

jmaerz Sep 5, 2022 •

edited

Loading

jmaerz Sep 5, 2022

TomasTorsvik Sep 5, 2022

jmaerz Sep 5, 2022

jmaerz Sep 5, 2022

TomasTorsvik Sep 5, 2022

jmaerz Sep 5, 2022

TomasTorsvik Sep 5, 2022

jmaerz Sep 5, 2022

TomasTorsvik Sep 5, 2022

jmaerz Sep 5, 2022

JorgSchwinger Sep 15, 2022

jmaerz Sep 15, 2022

TomasTorsvik Sep 5, 2022

jmaerz Sep 5, 2022

JorgSchwinger Sep 15, 2022

jmaerz Sep 15, 2022

jmaerz Sep 15, 2022

JorgSchwinger Sep 15, 2022

jmaerz Sep 15, 2022

jmaerz Sep 15, 2022

JorgSchwinger Sep 15, 2022

jmaerz Sep 15, 2022

JorgSchwinger Sep 15, 2022

jmaerz Sep 15, 2022

jmaerz commented Sep 15, 2022

TomasTorsvik commented Sep 15, 2022

JorgSchwinger commented Sep 15, 2022

		enddo

		sedict = 1.e-9 * dtbgc ! Moecular diffusion coefficient

	sedict = 1.e-9 * dtbgc ! Moecular diffusion coefficient
	sedict = 1.e-9 * dtbgc ! Molecular diffusion coefficient

	disso_poc = 0.01 / 86400. * dtbgc ! disso=3.e-5 was quite high
	disso_poc = 0.01 / 86400. * dtbgc

	sed_denit = 0.01/86400. * dtbgc !ik denit = 1.e-6*dtbgc
	sed_denit = 0.01/86400. * dtbgc

	frac = porsol(i,j,ks)*seddw(ks) !changed k to ks, ik
	frac = porsol(i,j,ks)*seddw(ks)

Lon-lat variable sediment porosity #189

Lon-lat variable sediment porosity #189

Conversation

jmaerz commented Sep 2, 2022

jmaerz commented Sep 2, 2022

TomasTorsvik commented Sep 2, 2022 • edited Loading

JorgSchwinger commented Sep 3, 2022

jmaerz commented Sep 5, 2022 • edited Loading

TomasTorsvik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmaerz Sep 5, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmaerz commented Sep 15, 2022

TomasTorsvik commented Sep 15, 2022

JorgSchwinger commented Sep 15, 2022

TomasTorsvik commented Sep 2, 2022 •

edited

Loading

jmaerz commented Sep 5, 2022 •

edited

Loading

jmaerz Sep 5, 2022 •

edited

Loading