Skip to content

Conversation

@galargh
Copy link
Contributor

@galargh galargh commented Aug 12, 2025

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

Barring the OOM in vectorized/solady, this PR establishes the new baseline for regression tests where everything's passing - https://github.com/NomicFoundation/hardhat/actions/runs/16910142358

Unfortunately, we did have to exclude a lot more tests. The majority of errors in the tests that we had to exclude show up as reverts of a kind.

The other 2 groups that we should look into:

  1. OOM in vectorized/solady
  2. the path * is not allowed to be accessed for read/write operations which looks like a regression since build: upgrade to @nomicfoundation/edr v0.12.0-next.4 #7119 where it was last verified to work

Finally, we had to exclude sablier-labs/lockup from the solidity-test preset as the test execution there now hangs on, seemingly, forever. This likely has to do with the remappings that we had to introduce there for the compilation to pass src/=src/ and tests/=tests/. Maybe this creates some sort of circular, infinite loop somewhere.

@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2025

⚠️ No Changeset found

Latest commit: f014f8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@galargh galargh added the no changeset needed This PR doesn't require a changeset label Aug 12, 2025
@galargh galargh added this pull request to the merge queue Aug 12, 2025
Merged via the queue into main with commit 0798240 Aug 12, 2025
20 checks passed
@galargh galargh deleted the regression-tests branch August 12, 2025 14:22
@github-project-automation github-project-automation bot moved this from Backlog to Done in Hardhat Aug 12, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no changeset needed This PR doesn't require a changeset

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants