Skip to content

Conversation

@popescuoctavian
Copy link
Contributor

@popescuoctavian popescuoctavian commented Aug 4, 2025

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this - tests already in place

This PR makes the necessary changes on Hardhat to adopt the new file system permissions config interface, integrated into EDR in this PR. These changes modify the permission interface to separate file and directory permissions to prevent users from unawarely expose themselves by sharing access to important project directories.

Confirmed the changes are working as expected by running the Regression tests workflow.

The changes were also tested with linking of local HH build into a HH3 project, on all the tests implemented in EDR.

I upgrade the dependency for EDR to @nomicfoundation/edr v0.12.0-next.4, with the following changes:

Minor Changes

  • 6640dda: Changed the file system permission config interface for Solidity tests, to mitigate EVM sandbox escape through cheatcodes.

@popescuoctavian popescuoctavian self-assigned this Aug 4, 2025
@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2025

🦋 Changeset detected

Latest commit: e98ded3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
hardhat Minor
@nomicfoundation/hardhat-errors Minor
@nomicfoundation/hardhat-ethers-chai-matchers Minor
@nomicfoundation/hardhat-ignition Minor
@nomicfoundation/ignition-core Minor
@nomicfoundation/hardhat-ignition-ethers Minor
@nomicfoundation/ignition-ui Minor
@nomicfoundation/hardhat-ignition-viem Minor
@nomicfoundation/hardhat-keystore Minor
@nomicfoundation/hardhat-mocha Minor
@nomicfoundation/hardhat-network-helpers Minor
@nomicfoundation/hardhat-node-test-reporter Minor
@nomicfoundation/hardhat-node-test-runner Minor
@nomicfoundation/hardhat-test-utils Minor
@nomicfoundation/hardhat-typechain Minor
@nomicfoundation/hardhat-utils Minor
@nomicfoundation/hardhat-toolbox-mocha-ethers Minor
@nomicfoundation/hardhat-verify Minor
@nomicfoundation/hardhat-viem Minor
@nomicfoundation/hardhat-viem-assertions Minor
@nomicfoundation/hardhat-zod-utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@popescuoctavian popescuoctavian force-pushed the popescuoctavian/fsPermissions branch from 0f18f87 to e98ded3 Compare August 5, 2025 11:02
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

hardhat

Total size of the bundle: 54M
Total number of dependencies (including transitive): 38

List of dependencies (sorted by size)
48M	total
20M	esbuild
7.2M	@sentry/core
5.2M	zod
2.7M	micro-eth-signer
1.9M	@noble/curves
1.7M	undici
1.2M	@noble/hashes
864K	@streamparser/json
860K	@nomicfoundation/hardhat-utils
624K	micro-packed
592K	tsx
544K	fast-equals
516K	@nomicfoundation/hardhat-errors
492K	@scure/bip39
448K	@nomicfoundation/edr
408K	json-stream-stringify
368K	ethereum-cryptography
332K	@streamparser/json-node
320K	enquirer
288K	semver
200K	ws
168K	@scure/base
136K	get-tsconfig
136K	adm-zip
96K	@scure/bip32
92K	chalk
72K	@nomicfoundation/solidity-analyzer
68K	debug
64K	@nomicfoundation/hardhat-zod-utils
56K	rfdc
48K	ansi-colors
44K	resolve.exports
40K	resolve-pkg-maps
36K	p-map
24K	strip-ansi
24K	env-paths
24K	ansi-regex
20K	ms

@popescuoctavian popescuoctavian changed the title fix: mitigate EVM sandbox escape through cheatcodes build: upgrade to @nomicfoundation/edr v0.12.0-next.4 Aug 5, 2025
@popescuoctavian popescuoctavian requested a review from a team August 5, 2025 11:27
@popescuoctavian popescuoctavian marked this pull request as ready for review August 5, 2025 11:27
@galargh galargh added this pull request to the merge queue Aug 5, 2025
Merged via the queue into v-next with commit 3c7131d Aug 5, 2025
247 checks passed
@galargh galargh deleted the popescuoctavian/fsPermissions branch August 5, 2025 11:38
@github-project-automation github-project-automation bot moved this from Backlog to Done in Hardhat Aug 5, 2025
@galargh galargh mentioned this pull request Aug 12, 2025
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants