Skip to content

Conversation

@alfietham
Copy link
Contributor

  • JOSE.JWT raises exceptions when JWT token string is invalid
  • this gracefully handles this case by handling raised exceptions

Fixes: #12

Picking up from #16 - since PR #16 haven't moved since 8 months ago

(p.s. very nice package @Nickforall :)

* JOSE.JWT raises exceptions when JWT token string is invalid
* this gracefully handles this case by handling raised exceptions
@alfietham alfietham marked this pull request as draft December 30, 2021 21:50
@alfietham
Copy link
Contributor Author

Replaced with #43

@alfietham alfietham closed this Dec 30, 2021
Copy link
Owner

@Nickforall Nickforall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks for the contributions! I'll push it to hex tomorrow.

@alfietham
Copy link
Contributor Author

Looks awesome, thanks for the contributions! I'll push it to hex tomorrow.

Oops sorry - I've replaced this with #43 assuming no one would see it this quick.

Code-wise both PRs are exactly the same. Just different fork branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not raise on invalid JWT, return error tuple

2 participants