Do not raise on invalid JWTs #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nickforall
requested changes
Apr 26, 2021
Owner
Nickforall
left a comment
Nickforall
left a comment
There was a problem hiding this comment.
It indeed raises on every occasion now, including some expected raises, for example when the issuer config is not set.
I think extracting this call and wrapping it in a resuce would suffice
Line 40 in 9fed2ce
This was referenced Dec 30, 2021
Owner
|
Closing this as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #12
Update: I see it needs some work since it's catching each and every error, thus breaking some tests. I'll get back to it right when I get some free time over here. :)