Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only persist net SStore changes #6931

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Only persist net SStore changes #6931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions src/Nethermind/Nethermind.State/PersistentStorageProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,8 @@ protected override void CommitCore(IStorageTracer tracer)
_logger.Trace($" Update {change.StorageCell.Address}_{change.StorageCell.Index} V = {change.Value.ToHexString(true)}");
}

StorageTree tree = GetOrCreateStorage(change.StorageCell.Address);
Db.Metrics.StorageTreeWrites++;
toUpdateRoots.Add(change.StorageCell.Address);
tree.Set(change.StorageCell.Index, change.Value);
SaveToTree(toUpdateRoots, change);

if (isTracing)
{
trace![change.StorageCell] = new ChangeTrace(change.Value);
Expand Down Expand Up @@ -204,8 +202,23 @@ protected override void CommitCore(IStorageTracer tracer)
}
}

private void SaveToTree(HashSet<Address> toUpdateRoots, Change change)
{
if (_originalValues.TryGetValue(change.StorageCell, out byte[] initialValue) &&
initialValue.AsSpan().SequenceEqual(change.Value))
{
// no need to update the tree if the value is the same
return;
}

StorageTree tree = GetOrCreateStorage(change.StorageCell.Address);
Db.Metrics.StorageTreeWrites++;
toUpdateRoots.Add(change.StorageCell.Address);
tree.Set(change.StorageCell.Index, change.Value);
}

/// <summary>
/// Commit persisent storage trees
/// Commit persistent storage trees
/// </summary>
/// <param name="blockNumber">Current block number</param>
public void CommitTrees(long blockNumber)
Expand Down
Loading