Only persist net SStore changes

[benaadams]

Changes

• Only persist net SStore changes (don't write where value is same as initial)
  • Common pattern of this in Solidity is a reentrency flag, where value is set at start of txn and then set back at end

Types of changes

What types of changes does your code introduce?

• Optimization

Logging the counts of changes (where above 0) in this function. This write is per tx so many per block, if cache was pre block it would be further reduced.

18 Apr 12:33:17 | Rerunning block after reorg or pruning: 19668566 (0x76dfb9...b0b38f)
18 Apr 12:33:17 | Skipped SStore writes 3 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 3 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 3 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 4 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 5 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 2 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 4 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 61 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 1 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 3 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 1 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 4 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 2 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 1 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 1 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 1 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 1 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 1 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 1 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 2 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 5 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 4 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 5 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 4 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 4 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 3 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 3 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 3 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 1 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 4 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 4 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 3 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 4 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 3 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 1 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 3 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 3 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 4 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 3 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 1 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 3 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 4 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 4 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 3 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 2 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 4 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 1 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 1 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 1 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 1 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 1 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 4 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 1 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 8 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 2 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 4 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 3 (Initial value same as changed value)
18 Apr 12:33:17 | Skipped SStore writes 3 (Initial value same as changed value)
18 Apr 12:33:17 | Rerunning block after reorg or pruning: 19668567 (0x1517ca...131f5c)

Testing

Requires testing

• No

[benaadams]

Hive tests https://github.com/NethermindEth/nethermind/actions/runs/8737403543

[benaadams]

Hive tests pass