Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config DNS discovery Resolves #4321 #4815

Merged
merged 5 commits into from
Nov 22, 2022

Conversation

OlegJakushkin
Copy link
Contributor

Resolves #4321

Changes:

  • Added configuration option for Dns Discovery similar to what geth has.

Note: we have no verification of a DNS list signer! Following EIP-1459 "public key must be known to the client to verify the list." Thus there shall be a list of public keys that a client allows, and we shall check against it. Geth also seems not to check it.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Tested only on public DNS nodes.

Added a space
Copy link
Contributor

@smartprogrammer93 smartprogrammer93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the description of the config, all looks good.

src/Nethermind/Nethermind.Network/Config/INetworkConfig.cs Outdated Show resolved Hide resolved
@rubo rubo added the network label Nov 18, 2022
@OlegJakushkin OlegJakushkin merged commit b9cd4cc into master Nov 22, 2022
@OlegJakushkin OlegJakushkin deleted the fix/config-node-discovery-4321 branch November 22, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make node discovery configurable
3 participants