Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make node discovery configurable #4321

Closed
rubo opened this issue Jul 26, 2022 · 0 comments · Fixed by #4815
Closed

Make node discovery configurable #4321

rubo opened this issue Jul 26, 2022 · 0 comments · Fixed by #4815
Assignees
@OlegJakushkin
Labels
configuration discovery enhancement good first issue

Comments

@rubo
Copy link
Contributor

rubo commented Jul 26, 2022

Currently, there's no way to configure the ENR tree lookup. It's hardcoded. There's should be an option like the one of Geth.

Requested on Discord:

Is there any documentation available about how to use DNS discovery (EIP-1459) with Nethermind?
So after we have a signed txt record and compiled a list of nodes, how and where should we configure the domain name?
I mean, there should be a place in our configuration that points to the DNS name so that it can be consumed (fetch the txt record, validate the signature, read the list, etc) by the node.
@OlegJakushkin OlegJakushkin mentioned this issue Oct 25, 2022
Merged
12 tasks
OlegJakushkin added a commit that referenced this issue Nov 22, 2022
@OlegJakushkin
Added config DNS discovery Resolves #4321 (#4815)
b9cd4cc 
* Added DiscoveryDns argument to configuration

Similar to how it is in Geth

* Code cleanup

Added a space

* Minor description fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlegJakushkin OlegJakushkin

Labels
configuration discovery enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added config DNS discovery Resolves #4321 NethermindEth/nethermind
3 participants
@rubo @OlegJakushkin @dceleda