Refactor/eth66

[asdacap]

Resolves #4714

• Conform to eth66.

Changes:

• Add request/response mapping.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Other (please describe):

Testing

Requires testing

• Yes
• No

In case you checked yes, did you write tests??

• Yes
• No

Comments about testing , should you have some (optional)

• 4 smoke test run can sync.

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[marcindsobczak]

Wow, you are so fast!

I think we need benchmark to compare it before and after changes. Any ideas who can help us? Maybe @kamilchodola ?

[LukaszRozmej]

How does it stack up comparing with previous version? Any improvements (doesn't have to be total time, but time in this area or memory)

[LukaszRozmej]

The main question still is: Is this beneficial in any way, because it looks like it we already have request->response mapping through CompletionSource, so what benefits this brings us?

[asdacap]

I think for now its largely for conformance reason. Maybe one day of the client would response out of order for performance reason, eg, some block is on cache some not. If that happen sync might break.

[asdacap]

Finally got some runs to complete. Before vs after (EPYC cpu):

• Lighthouse 4 hours 40 minute (7713) vs 22 hours 10 minute (7501).
• Lodestar 20 hours 20 minute (7501) vs 3 hours 55 minute (7713).
• Prysm 7 hours 40 minute (7542) vs 15 hours 20 minute (7501).
• Teku 14 hours 30 minute (7501) vs 9 hours 55 minute (7542).

In conclusion, I have terrible luck. None of the four pair have the same CPU. At least they all can sync.

[asdacap]

Another runs. Before vs after:

• Lighthouse 4 hours 30 minute vs 4 hours
• Lodestar 3 hours 40 minute (EPYC 7642) vs 3 hours 40 minute.
• Prysm 3 hours 30 minute vs 3 hours 40 minute.
• Teku 3 hours 40 minute vs 6 hours (EPYC 7542).
  Everything else is EPYC 7713.