Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop MessageQueues, start pairing requests and responds by requestId #4714

Closed
marcindsobczak opened this issue Oct 5, 2022 · 0 comments · Fixed by #4758
Closed

Drop MessageQueues, start pairing requests and responds by requestId #4714

marcindsobczak opened this issue Oct 5, 2022 · 0 comments · Fixed by #4758
Assignees
@asdacap
Labels
difficult It requires detailed knowledge of the codebase and changes can easily lead to severe issues. a network performance refactoring

Comments

@marcindsobczak
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We are using MessageQueues to pair requests and responds. In post-eth66 world there is requestId and we do not need queues any more

Describe the solution you'd like
Don't wait for response after sending message. Send and then compare by requestId. It can significantly improve our eth66 networking and can be changed in snap protocol as well

Additional context
I started implementing it in early 2022, but failed on it. Some ideas are on branch:
https://github.com/NethermindEth/nethermind/tree/refactor/eth66
@dceleda dceleda added the difficult It requires detailed knowledge of the codebase and changes can easily lead to severe issues. a label Oct 5, 2022
@marcindsobczak marcindsobczak mentioned this issue Oct 7, 2022
Merged
12 tasks
@asdacap asdacap self-assigned this Oct 12, 2022
@asdacap asdacap mentioned this issue Oct 13, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asdacap asdacap

Labels
difficult It requires detailed knowledge of the codebase and changes can easily lead to severe issues. a network performance refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor/eth66 NethermindEth/nethermind
3 participants
@asdacap @dceleda @marcindsobczak