Broadcast best persistent txs instead of random

src/Nethermind/Nethermind.TxPool/Collections/SortedPool.cs

@@ -236,26 +236,23 @@ public IEnumerable<TValue> TryGetStaleValues(TGroupKey groupKey, Predicate<TValu
         {
             if (_buckets.TryGetValue(groupKey, out SortedSet<TValue>? bucket))
             {
-                if (!where(bucket.First()))
-                {
-                    return ArraySegment<TValue>.Empty;
-                }
-
-                List<TValue> staleValues = new() { bucket.First() };
-                foreach (TValue value in bucket.Skip(1))
+                using SortedSet<TValue>.Enumerator enumerator = bucket.GetEnumerator();
+                bool keepGoing = true;
+                List<TValue>? list = null;
+
+                while (keepGoing && enumerator.MoveNext())
                 {
-                    if (where(value))
-                    {
-                        staleValues.Add(value);
-                    }
-                    else
+                    keepGoing = where(enumerator.Current);
+                    if (keepGoing)
                     {
-                        return staleValues;
+                        list ??= new List<TValue>();
+                        list.Add(enumerator.Current);
                     }
+                    else return list ?? Enumerable.Empty<TValue>();
                 }
-                return staleValues;
+                return list!;
             }
-            return ArraySegment<TValue>.Empty;
+            return Enumerable.Empty<TValue>();
         }
 
         /// <summary>