Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast best persistent txs instead of random #3768

Merged
merged 27 commits into from
Feb 11, 2022

Conversation

marcindsobczak
Copy link
Contributor

@marcindsobczak marcindsobczak commented Jan 27, 2022

Changes:

  • pick and broadcast declared percent (PeerNotificationThreshold) of best persistent transactions instead of random transactions
  • broadcast persistent transactions only when their MaxFeePerGas >= CurrentBaseFee
  • remove stale transactions from persistent transactions

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

@marcindsobczak marcindsobczak marked this pull request as ready for review February 7, 2022 09:49
@LukaszRozmej LukaszRozmej merged commit e99aa63 into master Feb 11, 2022
@LukaszRozmej LukaszRozmej deleted the refactor/persistent_broadcast branch February 11, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants