Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented new approach of gas estimation. #3723

Merged
merged 10 commits into from
Jan 7, 2022

Conversation

kjazgar
Copy link
Contributor

@kjazgar kjazgar commented Dec 23, 2021

Fixes | Closes | Resolves #

Changes:

Changed CalculateEstimate method to use binary search over gas limit.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Comments about testing , should you have some (optional)

Tests had already been written for this feature and all passed.

@LukaszRozmej LukaszRozmej linked an issue Jan 4, 2022 that may be closed by this pull request
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, few details can still be improved.

src/Nethermind/Nethermind.Evm/Tracing/GasEstimator.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm/Tracing/GasEstimator.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm/Tracing/GasEstimator.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm/Tracing/GasEstimator.cs Outdated Show resolved Hide resolved
@LukaszRozmej LukaszRozmej merged commit bc90e9f into master Jan 7, 2022
@LukaszRozmej LukaszRozmej deleted the estimate_gas_new_approach branch January 7, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Low gas limit estimation for Gnosis Safe
2 participants