Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low gas limit estimation for Gnosis Safe #3577

Closed
dasanra opened this issue Nov 3, 2021 · 1 comment · Fixed by #3723
Closed

Low gas limit estimation for Gnosis Safe #3577

dasanra opened this issue Nov 3, 2021 · 1 comment · Fixed by #3723
Assignees

Comments

@dasanra
Copy link

dasanra commented Nov 3, 2021

Describe the bug
Whenever we try to execute a transaction in Gnosis Safe we try to estimate the gas limit. In many cases we do this when one signature is still pending, so the last user can sign and execute in the same step. For some reason, Nethermind nodes are having problems into estimating the gas limit in this situation, and is the only type of node where we find this difficulties.

For estimating the gas we are just calling the estimateGas function from web3.

Funny thing is that executing a call to check if the transaction will go through returns a revert message. When adding a higher gas limit manually the call method will return success when we get the correct value for gasLimit

To Reproduce
Steps to reproduce the behavior:

  1. You have the option to create a Gnosis Safe for testing on xDai https://xdai.gnosis-safe.io/app/
  2. You will need to setup a Safe with any configuration you want
  3. When executing any kind of transaction you will find that sending the transaction with the last signer (at create time if threshold is just one signer), a potential error message is shown. If ignored and the transaction is sent will revert because out of gas. Adding more gas until the error is not visible will make the transaction work perfectly

Expected behavior
I would expect that the node returns a valid gas limit to execute the transaction without issues

@tkstanczak
Copy link
Member

Needs fixing EstimateGasTracer - discussed with @LukaszRozmej on the call.

@LukaszRozmej LukaszRozmej linked a pull request Jan 4, 2022 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants