Perf/spec binary search

src/Nethermind/Nethermind.Blockchain/Spec/ChainHeadSpecProvider.cs

@@ -25,6 +25,9 @@ public class ChainHeadSpecProvider : IChainHeadSpecProvider
     {
         private readonly ISpecProvider _specProvider;
         private readonly IBlockFinder _blockFinder;
+        private long _lastHeader = -1;
+        private IReleaseSpec? _headerSpec = null;
+        private readonly object _lock = new();
 
         public ChainHeadSpecProvider(ISpecProvider specProvider, IBlockFinder blockFinder)
         {
@@ -42,6 +45,28 @@ public ChainHeadSpecProvider(ISpecProvider specProvider, IBlockFinder blockFinde
 
         public long[] TransitionBlocks => _specProvider.TransitionBlocks;
 
-        public IReleaseSpec GetSpec() => GetSpec(_blockFinder.FindBestSuggestedHeader()?.Number ?? 0);
+        public IReleaseSpec GetCurrentHeadSpec()
+        {
+            long headerNumber = _blockFinder.FindBestSuggestedHeader()?.Number ?? 0;
+
+            // we are fine with potential concurrency issue here, that the spec will change
+            // between this if and getting actual header spec
+            // this is used only in tx pool and this is not a problem there
+            if (headerNumber == _lastHeader)
+            {
+                IReleaseSpec releaseSpec = _headerSpec;
+                if (releaseSpec is not null)
+                {
+                    return releaseSpec;
+                }
+            }
+
+            // we want to make sure updates to both fields are consistent though
+            lock (_lock)
+            {
+                _lastHeader = headerNumber;
+                return _headerSpec = GetSpec(headerNumber);
+            }
+        }
     }
 }

src/Nethermind/Nethermind.Core.Test/FixedBlockChainHeadSpecProvider.cs

@@ -43,6 +43,6 @@ public IReleaseSpec GetSpec(long blockNumber)
 
         public long[] TransitionBlocks => _specProvider.TransitionBlocks;
 
-        public IReleaseSpec GetSpec() => GetSpec(_fixedBlock);
+        public IReleaseSpec GetCurrentHeadSpec() => GetSpec(_fixedBlock);
     }
 }

src/Nethermind/Nethermind.Core/Specs/IChainHeadSpecProvider.cs

@@ -19,6 +19,6 @@ namespace Nethermind.Core.Specs
 {
     public interface IChainHeadSpecProvider : ISpecProvider
     {
-        IReleaseSpec GetSpec();
+        IReleaseSpec GetCurrentHeadSpec();
     }
 }

src/Nethermind/Nethermind.Specs/ChainSpecStyle/ChainSpecBasedSpecProvider.cs

@@ -18,6 +18,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Reflection;
+using Nethermind.Core.Collections;
 using Nethermind.Core.Specs;
 using Nethermind.Int256;
 
@@ -170,28 +171,15 @@ private void BuildTransitions()
 
         public IReleaseSpec GenesisSpec => _transitions.Length == 0 ? null : _transitions[0].Release;
 
-        public IReleaseSpec GetSpec(long blockNumber)
-        {
-            if (_transitions.Length == 0)
-            {
-                return null;
-            }
+        public IReleaseSpec GetSpec(long blockNumber) =>
+            _transitions.TryGetSearchedItem(blockNumber,
+                CompareTransitionOnBlock,
+                out (long BlockNumber, IReleaseSpec Release) transition)
+                ? transition.Release
+                : null;
 
-            IReleaseSpec spec = _transitions[0].Release;
-            for (int i = 1; i < _transitions.Length; i++)
-            {
-                if (blockNumber >= _transitions[i].BlockNumber)
-                {
-                    spec = _transitions[i].Release;
-                }
-                else
-                {
-                    break;
-                }
-            }
-
-            return spec;
-        }
+        private static int CompareTransitionOnBlock(long blockNumber, (long BlockNumber, IReleaseSpec Release) transition) => 
+            blockNumber.CompareTo(transition.BlockNumber);
 
         public long? DaoBlockNumber => _chainSpec.DaoForkBlockNumber;
 

src/Nethermind/Nethermind.TxPool/Filters/DeployedCodeFilter.cs

@@ -36,7 +36,7 @@ public DeployedCodeFilter(IChainHeadSpecProvider specProvider, IAccountStateProv
             _stateProvider = stateProvider;
         }
         public (bool Accepted, AddTxResult? Reason) Accept(Transaction tx, TxHandlingOptions txHandlingOptions) => 
-            _stateProvider.IsInvalidContractSender(_specProvider.GetSpec(), tx.SenderAddress!) 
+            _stateProvider.IsInvalidContractSender(_specProvider.GetCurrentHeadSpec(), tx.SenderAddress!) 
                 ? (false, AddTxResult.SenderIsContract) 
                 : (true, null);
     }

src/Nethermind/Nethermind.TxPool/Filters/FeeTooLowFilter.cs

@@ -45,7 +45,7 @@ public FeeToLowFilter(IChainHeadInfoProvider headInfo, IAccountStateProvider acc
 
         public (bool Accepted, AddTxResult? Reason) Accept(Transaction tx, TxHandlingOptions handlingOptions)
         {
-            IReleaseSpec spec = _specProvider.GetSpec();
+            IReleaseSpec spec = _specProvider.GetCurrentHeadSpec();
             Account account = _accounts.GetAccount(tx.SenderAddress!);
             UInt256 balance = account.Balance;
             UInt256 affordableGasPrice = tx.CalculateAffordableGasPrice(spec.IsEip1559Enabled, _headInfo.CurrentBaseFee, balance);

src/Nethermind/Nethermind.TxPool/Filters/MalformedTxFilter.cs

@@ -39,7 +39,7 @@ public MalformedTxFilter(IChainHeadSpecProvider specProvider, ITxValidator txVal
 
         public (bool Accepted, AddTxResult? Reason) Accept(Transaction tx, TxHandlingOptions txHandlingOptions)
         {
-            IReleaseSpec spec = _specProvider.GetSpec();
+            IReleaseSpec spec = _specProvider.GetCurrentHeadSpec();
             if (!_txValidator.IsWellFormed(tx, spec))
             {
                 // It may happen that other nodes send us transactions that were signed for another chain or don't have enough gas.

src/Nethermind/Nethermind.TxPool/Filters/TooExpensiveTxFilter.cs

@@ -45,7 +45,7 @@ public TooExpensiveTxFilter(IChainHeadInfoProvider headInfo, IAccountStateProvid
 
         public (bool Accepted, AddTxResult? Reason) Accept(Transaction tx, TxHandlingOptions handlingOptions)
         {
-            IReleaseSpec spec = _specProvider.GetSpec();
+            IReleaseSpec spec = _specProvider.GetCurrentHeadSpec();
             Account account = _accounts.GetAccount(tx.SenderAddress!);
             UInt256 balance = account.Balance;
             UInt256 cumulativeCost = UInt256.Zero;

src/Nethermind/Nethermind.TxPool/TxPool.cs

@@ -286,7 +286,7 @@ private AddTxResult AddCore(Transaction tx, bool isPersistentBroadcast)
         {
             lock (_locker)
             {
-                bool eip1559Enabled = _specProvider.GetSpec().IsEip1559Enabled;
+                bool eip1559Enabled = _specProvider.GetCurrentHeadSpec().IsEip1559Enabled;
 
                 tx.GasBottleneck = tx.CalculateEffectiveGasPrice(eip1559Enabled, _headInfo.CurrentBaseFee);
                 bool inserted = _transactions.TryInsert(tx.Hash, tx, out Transaction? removed);
@@ -363,14 +363,14 @@ private AddTxResult AddCore(Transaction tx, bool isPersistentBroadcast)
                 {
                     if (previousTxBottleneck == null)
                     {
-                        previousTxBottleneck = tx.CalculateAffordableGasPrice(_specProvider.GetSpec().IsEip1559Enabled,
+                        previousTxBottleneck = tx.CalculateAffordableGasPrice(_specProvider.GetCurrentHeadSpec().IsEip1559Enabled,
                             _headInfo.CurrentBaseFee, balance);
                     }
 
                     if (tx.Nonce == currentNonce + i)
                     {
                         UInt256 effectiveGasPrice =
-                            tx.CalculateEffectiveGasPrice(_specProvider.GetSpec().IsEip1559Enabled,
+                            tx.CalculateEffectiveGasPrice(_specProvider.GetCurrentHeadSpec().IsEip1559Enabled,
                                 _headInfo.CurrentBaseFee);
                         gasBottleneck = UInt256.Min(effectiveGasPrice, previousTxBottleneck ?? 0);
                     }