Perf/spec binary search #3647
Merged
Perf/spec binary search #3647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkstanczak
reviewed
Nov 29, 2021
| return spec; | ||
| } | ||
| public IReleaseSpec GetSpec(long blockNumber) => | ||
| _transitions.TryGetSearchedItem(blockNumber, |
There was a problem hiding this comment.
unnecessary lambda allocation on GetSpec which is called very often
There was a problem hiding this comment.
fixed by static method
tkstanczak
reviewed
Nov 29, 2021
| public IReleaseSpec GetSpec() | ||
| { | ||
| long headerNumber = _blockFinder.FindBestSuggestedHeader()?.Number ?? 0; | ||
| if (headerNumber == _lastHeader) |
dceleda
reviewed
Nov 29, 2021
| if (headerNumber == _lastHeader) | ||
| { | ||
| IReleaseSpec releaseSpec = _headerSpec; | ||
| if (headerNumber == _lastHeader) |
There was a problem hiding this comment.
I don't know the functionality so I need some clarification :)
GetSpec returns the best cached spec.
Does it have to be the latest? We don't have a monitor here, so it can change between ln54 and ln58. Which means we don't care if it's the latest. So if we don't care that it's the latest then we don't need that double check.
| } | ||
| } | ||
|
|
||
| lock (_lock) |
There was a problem hiding this comment.
Again, what if headerNumber changed between ln50 and ln65?
We will overwrite _headerSpec with the previous one.
dceleda
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Binary search for spec transitions
Store head spec through calls
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??