address name contraction issues in argo-workflows create #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikonen
reviewed
Oct 7, 2024
Comment on lines
+311
to
+314
| " To comply with new naming restrictions on Argo " | ||
| "Workflows, this deployment replaced the\npreviously " | ||
| "deployed workflow {v1_workflow_name}.\n".format( | ||
| v1_workflow_name=obj._v1_workflow_name |
There was a problem hiding this comment.
we could also check whether v1_workflow_name exists or not, and cut this alert out if we did not replace an old deployment
Comment on lines
+518
to
+519
| # TODO: We can create better names that try to preserve the flow name | ||
| workflow_name = "%s-%s" % (workflow_name[: limit - 6], name_hash) |
There was a problem hiding this comment.
we could use current.flow_name as the base and append the hash which comes from the current.project_flow_name if the flow name is the most significant info in the template name
Though one issue with this would be that validate_run_id relies on checking whether project/branch are part of the generated workflow_name. This needs an overhaul in any case though, as it will most likely start breaking due to the new limits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remaining items -
--namefor long names for CLI args except create