feature: limit argo workflow name length #1608
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first draft for fixing argo workflows workflow name maxLength. Previously 253 characters have been allowed, but this causes launching workflows through Argo UI to fail for names longer than 63 characters, as Argo wants to set the workflow template name as a Kubernetes label for the workflow.
Idea is to introduce a new limit of 63 characters, which checks for existence of a >63char deployment upon name resolving and raises an exception in case one is found. User can circumvent this by applying a flag to use the old name lengths for argo workflow commands:
Note: This can in some cases affect GitOps setups and other CI solutions for deploying flows. An easy workaround for those would to apply the
--old-name-length
flag for deployments to retain the original functionality.attempts to address #1521 and unblock implementing #1416