Skip to content

Place block statements before regular HTML attributes instead of afte… #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Place block statements before regular HTML attributes instead of afte… #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,15 +250,19 @@ A style guide for the [HTML Template Language](https://docs.adobe.com/docs/en/ht
</ul>
```

- [4.7](#4.7) <a name='4.7'></a> **Always place block statements after the normal HTML attributes.**
- [4.7](#4.7) <a name='4.7'></a> **Always place block statements before the regular HTML attributes.**


The reason for that is that regular HTML attributes might use HTL variables which have been declared in the same element via `data-sly-use`. One should always declare things before using them. Also HTL block elements might influence if the element appears at all (via `data-sly-test`) or multiple times (via `data-sly-repeat`) and therefore are just too important to put them at the end of the attribute list. Further details in [issue 25](https://github.com/Netcentric/aem-htl-style-guide/issues/25).

```html
<!--/* Bad */-->
<p data-sly-test="${teaser.text}" class="teaser__text"></p>

<!--/* Good */-->
<p class="teaser__text" data-sly-test="${teaser.text}"></p>

<!--/* Good */-->
<p data-sly-test="${teaser.text}" class="teaser__text"></p>
```


- [4.8](#4.8) <a name='4.8'></a> **Always use existing HTML elements for your block statements if possible.**

Expand Down