Skip to content

Place block statements before regular HTML attributes instead of afte… #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2019
Merged

Place block statements before regular HTML attributes instead of afte… #26

merged 1 commit into from
Jan 30, 2019

Conversation

kwin
Copy link
Member

@kwin kwin commented Jan 18, 2019

…r them

This closes #25.

@kwin kwin requested review from ghenzler and felipeS January 18, 2019 15:02
@kwin kwin force-pushed the feature/issue-25 branch from 10269b2 to 80d6aec Compare January 18, 2019 15:49
@kwin kwin force-pushed the feature/issue-25 branch from 80d6aec to cdfa47d Compare January 18, 2019 15:50
felipeS
felipeS approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@felipeS felipeS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitively makes more sense to have block statements before HTML attributes.

@kwin kwin merged commit d19e029 into master Jan 30, 2019
@kwin kwin deleted the feature/issue-25 branch January 30, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeS felipeS felipeS approved these changes

@ghenzler ghenzler Awaiting requested review from ghenzler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reason for: 4.7 Always place block statements after the normal HTML attributes
2 participants
@kwin @felipeS