Warn user about unsupported FOV value #1586
Open
+36
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the case where neo_fov is larger than the maximum value supported by the engine renderer (90). We still want to allow setting these values as long as they're within the neo_fov bounds, but should warn the user about the possibility of graphical glitches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are restricted to supporting a max FOV of 90 by a limitation in the engine library renderer, for which we do not have access. As such, this patch resolves #1201 by warning the user about their unsupported FOV.
We probably don't want to hard-limit the upper bound of
neo_fovto 90, because it could lead to unhappy ultrawide/multi-monitor users, so this is the best(?) compromise for now.Toolchain
Linked Issues