Skip to content

Conversation

@Rainyan
Copy link
Collaborator

@Rainyan Rainyan commented Nov 23, 2025

Description

Fix the build_info.cmake for forked repos' CI to ensure that tags from upstream are fetched before attempting to read them.

This seems to be a bug from #1487 since the commit previous to that merge works fine.

Error logs

From a failed GH runner in a fork:

 fatal: No names found, cannot describe anything.
-- GIT_LATESTTAG: 
CMake Error at cmake/build_info.cmake:23 (message):
  Failed to get git tag
Call Stack (most recent call first):
  CMakeLists.txt:19 (include)


-- Configuring incomplete, errors occurred!

Toolchain

N/A

Linked Issues

Fix the build_info.cmake for forked repos to ensure that tags from
upstream are fetched before attempting to read them. This also fixes CI
runs for forks (since they wouldn't have fetched those tags before
running).
@Rainyan Rainyan marked this pull request as ready for review November 23, 2025 19:48
@Rainyan Rainyan requested a review from a team November 23, 2025 19:48
@Rainyan Rainyan changed the title Fix CMake for forked repos Fix CMake for forked repos' CI Nov 23, 2025
@Rainyan Rainyan changed the title Fix CMake for forked repos' CI Fix CMake for forked repos' CI runners Nov 23, 2025
@sunzenshen sunzenshen requested a review from a team November 24, 2025 04:27
Copy link
Contributor

@AdamTadeusz AdamTadeusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it uuuh looks fine I guess?

@Rainyan
Copy link
Collaborator Author

Rainyan commented Nov 24, 2025

it uuuh looks fine I guess?

Thanks for the confidence 🤣

To verify the bug:

The difference between these two branches is having the commit 0352dc3 applied as the HEAD.

If you want to reproduce it, enable the GitHub runner for your own fork, sync your fork's master to the upstream master, and watch the CI run explode.

But I'm no CMake master so if you or anyone else has opinions on a better way to fix this, then we could improve upon the fix later. Gonna merge this for now though.

@Rainyan Rainyan merged commit 114b34f into NeotokyoRebuild:master Nov 24, 2025
7 checks passed
@DESTROYGIRL DESTROYGIRL added the Build System CMake and other build-related stuff label Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build System CMake and other build-related stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants