Update key bindings on NT;RE update #1487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nullsystem
force-pushed
the
GH-1332_UpdateBindingOnUpdate
branch
4 times, most recently
from
903c2f7 to
c7b9096
Compare
sunzenshen
reviewed
Nov 18, 2025
sunzenshen
previously approved these changes
Nov 19, 2025
nullsystem
force-pushed
the
GH-1332_UpdateBindingOnUpdate
branch
from
34abd5d to
1e309c0
Compare
Collaborator
Author
|
@Masterkatze @sunzenshen Added |
* Keeps two hidden client convars: `cl_neo_cfg_version_major` and `cl_neo_cfg_version_minor` to keep track of which version the config was set for. Default value of "0" so it can recognize config previous to `cl_neo_cfg_version_...`. Major/minor versions are checked and set on client startup and will only set the new keybinds if the bind wasn't set, and the default key wasn't set. * The config version follows NT;RE `major.minor` version and extracts the version from the git tag with cmake, which puts it into `neo_version_number.h` header * Reviewers/testers can set `cl_neo_cfg_version_...` and unset relevant keybinds to emulate upgrading from older config to current * Currently sets mp3, kdinfo, ping, and aim keybind if config version < 22.0/unset * fixes NeotokyoRebuild#1332
nullsystem
force-pushed
the
GH-1332_UpdateBindingOnUpdate
branch
from
1e309c0 to
f0b655e
Compare
Masterkatze
approved these changes
Nov 21, 2025
sunzenshen
approved these changes
Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cl_neo_cfg_version_majorandcl_neo_cfg_version_minorto keep track of which version the config was set for. Default value of "0" so it can recognize config previous tocl_neo_cfg_version_.... Major/minor versions are checked and set on client startup and will only set the new keybinds if the bind wasn't set, and the default key wasn't set.major.minorversion and extracts the version from the git tag with cmake, which puts it intoneo_version_number.hheadercl_neo_cfg_version_...and unset relevant keybinds to emulate upgrading from older config to currentToolchain
Linked Issues